Prevent duplicate rent periods v1

2 years ago · bb3b4070bb
1 changed files with 3 additions and 1 deletions
--- a/app/services/merge/merge_organisations_service.rb
+++ b/app/services/merge/merge_organisations_service.rb
@ -38,7 +38,9 @@ private

  def merge_rent_periods(merging_organisation)
    merging_organisation.rent_periods.each do |rent_period|
-      @absorbing_organisation.organisation_rent_periods << OrganisationRentPeriod.new(rent_period:) unless @absorbing_organisation.rent_periods.include?(rent_period)
+      unless @absorbing_organisation.organisation_rent_periods.exists?(rent_period: rent_period)
+        @absorbing_organisation.organisation_rent_periods << OrganisationRentPeriod.new(rent_period:)
+      end
    end
  end