From bb3b4070bb78789f1b1810dbd1545f87df236ff3 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Tue, 8 Oct 2024 13:07:27 +0100
Subject: [PATCH] Prevent duplicate rent periods v1

---
 app/services/merge/merge_organisations_service.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/services/merge/merge_organisations_service.rb b/app/services/merge/merge_organisations_service.rb
index bcaad85a6..d825f3aac 100644
--- a/app/services/merge/merge_organisations_service.rb
+++ b/app/services/merge/merge_organisations_service.rb
@@ -38,7 +38,9 @@ private
 
   def merge_rent_periods(merging_organisation)
     merging_organisation.rent_periods.each do |rent_period|
-      @absorbing_organisation.organisation_rent_periods << OrganisationRentPeriod.new(rent_period:) unless @absorbing_organisation.rent_periods.include?(rent_period)
+      unless @absorbing_organisation.organisation_rent_periods.exists?(rent_period: rent_period)
+        @absorbing_organisation.organisation_rent_periods << OrganisationRentPeriod.new(rent_period:)
+      end
     end
   end