Browse Source

feat: add comments

pull/1951/head
natdeanlewissoftwire 3 years ago
parent
commit
baae652114
  1. 2
      app/services/csv/lettings_log_csv_service.rb
  2. 7
      app/services/csv/sales_log_csv_service.rb

2
app/services/csv/lettings_log_csv_service.rb

@ -237,7 +237,7 @@ module Csv
def person_details_not_known?(log, attribute) def person_details_not_known?(log, attribute)
details_known_field = PERSON_DETAILS.find { |key, _value| key == attribute }[1]["details_known_field"] details_known_field = PERSON_DETAILS.find { |key, _value| key == attribute }[1]["details_known_field"]
log[details_known_field] == 1 log[details_known_field] == 1 # Different in sales logs
end end
end end
end end

7
app/services/csv/sales_log_csv_service.rb

@ -49,11 +49,8 @@ module Csv
}.freeze }.freeze
PERSON_DETAILS = {}.tap { |hash| PERSON_DETAILS = {}.tap { |hash|
(2..6).each do |i| (1..6).each do |i|
hash["age#{i}_known"] = { "refused_code" => "-9", "refused_label" => "Not known", "details_known_field" => "details_known_#{i}" } hash["age#{i}_known"] = { "refused_code" => "-9", "refused_label" => "Not known", "details_known_field" => "details_known_#{i}" }
hash["sex#{i}"] = { "refused_code" => "R", "refused_label" => "Prefers not to say", "details_known_field" => "details_known_#{i}" }
hash["relat#{i}"] = { "refused_code" => "R", "refused_label" => "Prefers not to say", "details_known_field" => "details_known_#{i}" }
hash["ecstat#{i}"] = { "refused_code" => "10", "refused_label" => "Prefers not to say", "details_known_field" => "details_known_#{i}" }
end end
}.freeze }.freeze
@ -144,7 +141,7 @@ module Csv
def person_details_not_known?(log, attribute) def person_details_not_known?(log, attribute)
details_known_field = PERSON_DETAILS.find { |key, _value| key == attribute }[1]["details_known_field"] details_known_field = PERSON_DETAILS.find { |key, _value| key == attribute }[1]["details_known_field"]
log[details_known_field] == 1 log[details_known_field] == 2 # Different to lettings logs
end end
end end
end end

Loading…
Cancel
Save