Browse Source

fixup! CLDC-4145: Add a depends_on to ensure partner is hidden

remove unnecessary depends_on

make test ranges clearer
CLDC-4145-dont-ask-partner-for-children
Samuel Young 2 days ago
parent
commit
ba3a58e145
  1. 1
      app/models/form/lettings/pages/person_lead_partner.rb
  2. 8
      spec/models/form/lettings/pages/person_lead_partner_spec.rb

1
app/models/form/lettings/pages/person_lead_partner.rb

@ -2,7 +2,6 @@ class Form::Lettings::Pages::PersonLeadPartner < ::Form::Page
def initialize(id, hsh, subsection, person_index:) def initialize(id, hsh, subsection, person_index:)
super(id, hsh, subsection) super(id, hsh, subsection)
@id = "person_#{person_index}_lead_partner" @id = "person_#{person_index}_lead_partner"
@depends_on = [{ "details_known_#{person_index}" => 0 }]
@person_index = person_index @person_index = person_index
end end

8
spec/models/form/lettings/pages/person_lead_partner_spec.rb

@ -8,10 +8,6 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do
let(:subsection) { instance_double(Form::Subsection, form:) } let(:subsection) { instance_double(Form::Subsection, form:) }
let(:person_index) { 2 } let(:person_index) { 2 }
before do
allow(form).to receive(:start_year_2026_or_later?).and_return(false)
end
it "has correct subsection" do it "has correct subsection" do
expect(page.subsection).to eq(subsection) expect(page.subsection).to eq(subsection)
end end
@ -29,7 +25,7 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do
expect(page.id).to eq("person_2_lead_partner") expect(page.id).to eq("person_2_lead_partner")
end end
context "with start year >= 2025", metadata: { year: 25 } do context "with start year < 2026", metadata: { year: 25 } do
before do before do
allow(form).to receive(:start_year_2026_or_later?).and_return(false) allow(form).to receive(:start_year_2026_or_later?).and_return(false)
end end
@ -74,7 +70,7 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do
expect(page.id).to eq("person_3_lead_partner") expect(page.id).to eq("person_3_lead_partner")
end end
context "with start year >= 2025", metadata: { year: 25 } do context "with start year < 2026", metadata: { year: 25 } do
before do before do
allow(form).to receive(:start_year_2026_or_later?).and_return(false) allow(form).to receive(:start_year_2026_or_later?).and_return(false)
end end

Loading…
Cancel
Save