refactor: simplify

3 years ago · b93df70b3e
2 changed files with 1 additions and 5 deletions
--- a/app/models/scheme.rb
+++ b/app/models/scheme.rb
@ -255,10 +255,6 @@ class Scheme < ApplicationRecord
    status == :deactivated
  end

-  def has_confirmed_locations?
-    confirmed_locations_count.positive?
-  end
-
 private

  def confirmed_locations_count
--- a/app/models/validations/setup_validations.rb
+++ b/app/models/validations/setup_validations.rb
@ -23,7 +23,7 @@ module Validations::SetupValidations
  def validate_scheme_has_confirmed_locations_validation(record)
    return unless record.scheme

-    unless record.scheme.has_confirmed_locations?
+    unless record.scheme.locations.confirmed.any?
      record.errors.add :scheme_id, I18n.t("validations.scheme.no_completed_locations")
    end
  end