Browse Source

Remove child vlidation because buyer cannot be a child

pull/1079/head
Kat 4 years ago
parent
commit
a37cb3c266
  1. 4
      app/models/sales_log.rb
  2. 4
      app/models/validations/sales/financial_validations.rb
  3. 16
      spec/models/validations/sales/financial_validations_spec.rb

4
app/models/sales_log.rb

@ -63,10 +63,6 @@ class SalesLog < Log
false false
end end
def buyer_1_child?
ecstat1 == 9
end
LONDON_BOROUGHS = %w[ LONDON_BOROUGHS = %w[
E09000001 E09000001
E09000033 E09000033

4
app/models/validations/sales/financial_validations.rb

@ -4,9 +4,7 @@ module Validations::Sales::FinancialValidations
def validate_income1(record) def validate_income1(record)
if record.ecstat1 && record.income1 && record.ownershipsch == 1 if record.ecstat1 && record.income1 && record.ownershipsch == 1
if record.buyer_1_child? && record.income1.positive? if record.london_property?
record.errors.add :income1, I18n.t("validations.financial.income1.child_income")
elsif record.london_property?
record.errors.add :income1, I18n.t("validations.financial.income1.over_hard_max", hard_max: 90_000) if record.income1 > 90_000 record.errors.add :income1, I18n.t("validations.financial.income1.over_hard_max", hard_max: 90_000) if record.income1 > 90_000
elsif record.income1 > 80_000 elsif record.income1 > 80_000
record.errors.add :income1, I18n.t("validations.financial.income1.over_hard_max", hard_max: 80_000) record.errors.add :income1, I18n.t("validations.financial.income1.over_hard_max", hard_max: 80_000)

16
spec/models/validations/sales/financial_validations_spec.rb

@ -26,14 +26,6 @@ RSpec.describe Validations::Sales::FinancialValidations do
financial_validator.validate_income1(record) financial_validator.validate_income1(record)
expect(record.errors["income1"]).to be_empty expect(record.errors["income1"]).to be_empty
end end
it "validates income correctly if the ecstat is child" do
record.income1 = 1
record.ecstat1 = 9
financial_validator.validate_income1(record)
expect(record.errors["income1"])
.to include(match I18n.t("validations.financial.income1.child_income"))
end
end end
context "and a london borough" do context "and a london borough" do
@ -58,14 +50,6 @@ RSpec.describe Validations::Sales::FinancialValidations do
financial_validator.validate_income1(record) financial_validator.validate_income1(record)
expect(record.errors["income1"]).to be_empty expect(record.errors["income1"]).to be_empty
end end
it "validates income correctly if the ecstat is child" do
record.income1 = 1
record.ecstat1 = 9
financial_validator.validate_income1(record)
expect(record.errors["income1"])
.to include(match I18n.t("validations.financial.income1.child_income"))
end
end end
end end
end end

Loading…
Cancel
Save