baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

refactor: use if rather than unless... not in property validation

pull/1188/head
Sam Seed 3 years ago
parent
8738e45118
commit
9d0c3ef421
1 changed files with 1 additions and 1 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      app/models/validations/sales/property_validations.rb

2
app/models/validations/sales/property_validations.rb
Unescape View File

@ -11,7 +11,7 @@ module Validations::Sales::PropertyValidations
def validate_bedsit_number_of_beds(record) def validate_bedsit_number_of_beds(record)
return if record.proptype.blank? || record.beds.blank? return if record.proptype.blank? || record.beds.blank?
unless record.proptype != 2 || record.beds <= 1 if record.proptype == 2 && record.beds > 1
record.errors.add :proptype, I18n.t("validations.property.proptype.bedsits_have_max_one_bedroom") record.errors.add :proptype, I18n.t("validations.property.proptype.bedsits_have_max_one_bedroom")
record.errors.add :beds, I18n.t("validations.property.beds.bedsits_have_max_one_bedroom") record.errors.add :beds, I18n.t("validations.property.beds.bedsits_have_max_one_bedroom")
end end

Write Preview
Loading…
Cancel
Save