Browse Source

Display the soft validation errors on the soft-errors-valid page

pull/1615/head
Kat 3 years ago
parent
commit
9aa07099b5
  1. 8
      app/views/bulk_upload_lettings_data_check/soft_errors_valid.html.erb
  2. 8
      app/views/bulk_upload_sales_data_check/soft_errors_valid.html.erb
  3. 8
      spec/requests/bulk_upload_lettings_data_check_controller_spec.rb
  4. 8
      spec/requests/bulk_upload_sales_data_check_controller_spec.rb

8
app/views/bulk_upload_lettings_data_check/soft_errors_valid.html.erb

@ -12,6 +12,14 @@
<%= @bulk_upload.filename %>
</div>
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
<% @bulk_upload.bulk_upload_errors.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: errors_for_row) %>
<% end %>
</div>
</div>
<%= f.govuk_collection_radio_buttons :soft_errors_valid,
@form.options,
:id,

8
app/views/bulk_upload_sales_data_check/soft_errors_valid.html.erb

@ -12,6 +12,14 @@
<%= @bulk_upload.filename %>
</div>
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
<% @bulk_upload.bulk_upload_errors.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: errors_for_row) %>
<% end %>
</div>
</div>
<%= f.govuk_collection_radio_buttons :soft_errors_valid,
@form.options,
:id,

8
spec/requests/bulk_upload_lettings_data_check_controller_spec.rb

@ -20,6 +20,14 @@ RSpec.describe BulkUploadLettingsDataCheckController, type: :request do
expect(response.body).to include(bulk_upload.filename)
expect(response.body).to include("Are there any errors in these fields?")
end
it "shows the soft validation and lists the errors" do
get "/lettings-logs/bulk-upload-data-check/#{bulk_upload.id}/soft-errors-valid"
expect(response.body).to include("Row #{bulk_upload_errors.first.row}")
expect(response.body).to include("Tenant code")
expect(response.body).to include("some error")
end
end
describe "PATCH /lettings-logs/bulk-upload-data-check/:ID/soft-errors-valid" do

8
spec/requests/bulk_upload_sales_data_check_controller_spec.rb

@ -20,6 +20,14 @@ RSpec.describe BulkUploadSalesDataCheckController, type: :request do
expect(response.body).to include(bulk_upload.filename)
expect(response.body).to include("Are there any errors in these fields?")
end
it "shows the soft validation and lists the errors" do
get "/sales-logs/bulk-upload-data-check/#{bulk_upload.id}/soft-errors-valid"
expect(response.body).to include("Row #{bulk_upload_errors.first.row}")
expect(response.body).to include("Purchaser code")
expect(response.body).to include("some error")
end
end
describe "PATCH /sales-logs/bulk-upload-data-check/:ID/soft-errors-valid" do

Loading…
Cancel
Save