baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

update lettings log tests around derivations related to renewal

pull/1596/head
Arthur Campbell 3 years ago
parent
6c22ea8b55
commit
96a4e53c5f
1 changed files with 241 additions and 236 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 477
      spec/models/lettings_log_spec.rb

477
spec/models/lettings_log_spec.rb
Unescape View File

@ -1504,334 +1504,338 @@ RSpec.describe LettingsLog do
expect(record_from_db["has_benefits"]).to eq(1) expect(record_from_db["has_benefits"]).to eq(1)
end end
context "when it is a renewal" do context "when updating renewal" do
let!(:lettings_log) do let!(:lettings_log) do
described_class.create({ described_class.create({
managing_organisation: owning_organisation, managing_organisation: owning_organisation,
owning_organisation:, owning_organisation:,
created_by: created_by_user, created_by: created_by_user,
renewal: 1,
startdate: Time.zone.local(2021, 4, 10), startdate: Time.zone.local(2021, 4, 10),
created_at: Time.utc(2022, 2, 8, 16, 52, 15), created_at: Time.utc(2022, 2, 8, 16, 52, 15),
}) })
end end
it "correctly derives and saves waityear" do it "correctly derives the length of time on local authority waiting list" do
record_from_db = ActiveRecord::Base.connection.execute("select waityear from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(record_from_db["waityear"]).to eq(2) expect(lettings_log.waityear).to be 2
expect(lettings_log["waityear"]).to eq(2) lettings_log.update!(renewal: 0)
expect(lettings_log.waityear).to be nil
end end
it "correctly derives and saves underoccupation_benefitcap if year is 2021" do it "correctly derives the number of times previously offered since becoming available" do
record_from_db = ActiveRecord::Base.connection.execute("select underoccupation_benefitcap from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(record_from_db["underoccupation_benefitcap"]).to eq(2) expect(lettings_log.offered).to be 0
expect(lettings_log["underoccupation_benefitcap"]).to eq(2) lettings_log.update!(renewal: 0)
expect(lettings_log.offered).to be nil
end end
it "correctly derives and saves prevten" do it "correctly derives referral if the letting is a renewal and clears it if it is not" do
lettings_log.managing_organisation.update!({ provider_type: "PRP" }) lettings_log.update!(renewal: 1)
lettings_log.update!({ needstype: 1 }) expect(lettings_log.referral).to be 1
lettings_log.update!(renewal: 0)
expect(lettings_log.referral).to be nil
end
record_from_db = ActiveRecord::Base.connection.execute("select prevten from lettings_logs where id=#{lettings_log.id}").to_a[0] it "correctly derives voiddate if the letting is a renewal and clears it if it is not" do
expect(record_from_db["prevten"]).to eq(32) lettings_log.update!(renewal: 1)
expect(lettings_log["prevten"]).to eq(32) expect(lettings_log.voiddate).to eq lettings_log.startdate
lettings_log.update!(renewal: 0)
expect(lettings_log.voiddate).to be nil
end
lettings_log.managing_organisation.update!({ provider_type: "LA" }) it "correctly derives first_time_property_let_as_social_housing and clears it if it is not" do
lettings_log.update!({ needstype: 1 }) lettings_log.update!(renewal: 1)
expect(lettings_log.first_time_property_let_as_social_housing).to be 0
lettings_log.update!(renewal: 0)
expect(lettings_log.first_time_property_let_as_social_housing).to be nil
end
record_from_db = ActiveRecord::Base.connection.execute("select prevten from lettings_logs where id=#{lettings_log.id}").to_a[0] it "correctly derives vacancy reason and clears it if it is not" do
expect(record_from_db["prevten"]).to eq(30) lettings_log.update!(renewal: 1)
expect(lettings_log["prevten"]).to eq(30) expect(lettings_log.rsnvac).to be 14
lettings_log.update!(renewal: 0)
expect(lettings_log.rsnvac).to be nil
end end
it "correctly derives and saves referral" do # should have extra tests for whether it is derived when voiddate, mrcdate etc set and reset
record_from_db = ActiveRecord::Base.connection.execute("select referral from lettings_logs where id=#{lettings_log.id}").to_a[0] it "derives vacdays as 0 if log is renewal" do
expect(record_from_db["referral"]).to eq(1) lettings_log.update!(renewal: 1)
expect(lettings_log["referral"]).to eq(1) expect(lettings_log.vacdays).to be 0
end end
it "correctly derives and saves vacdays" do it "correctly derives underoccupation_benefitcap if log is a renewal from 2021/22" do
record_from_db = ActiveRecord::Base.connection.execute("select vacdays from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(record_from_db["vacdays"]).to eq(0) expect(lettings_log.underoccupation_benefitcap).to be 2
expect(lettings_log["vacdays"]).to eq(0)
end end
it "correctly derives and saves first_time_property_let_as_social_housing" do it "clears underoccupation_benefitcap if log is no longer a renewal" do
record_from_db = ActiveRecord::Base.connection.execute( lettings_log.update!(renewal: 1)
"select first_time_property_let_as_social_housing" \ expect(lettings_log.underoccupation_benefitcap).to be 2
" from lettings_logs where id=#{lettings_log.id}", lettings_log.update!(renewal: 0)
).to_a[0] expect(lettings_log.underoccupation_benefitcap).to be nil
expect(record_from_db["first_time_property_let_as_social_housing"]).to eq(0)
expect(lettings_log["first_time_property_let_as_social_housing"]).to eq(0)
end end
it "derives vacancy reason as relet" do it "clears underoccupation_benefitcap if log is no longer in 2021/22" do
record_from_db = ActiveRecord::Base.connection.execute("select rsnvac from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(record_from_db["rsnvac"]).to eq(14) expect(lettings_log.underoccupation_benefitcap).to be 2
expect(lettings_log["rsnvac"]).to eq(14) lettings_log.update!(startdate: Time.zone.now)
expect(lettings_log.underoccupation_benefitcap).to be nil
end end
context "when deriving renttype and unitletas" do context "when the log is general needs" do
before do context "and the managing organisation is a private registered provider" do
Timecop.freeze(Time.zone.local(2022, 1, 1)) before do
allow(FeatureToggle).to receive(:startdate_two_week_validation_enabled?).and_return(false) lettings_log.managing_organisation.update!(provider_type: "PRP")
lettings_log.update!(rent_type:, irproduct_other: "other") lettings_log.update!(needstype: 1, renewal: 1)
end end
after do it "correctly derives prevten" do
Timecop.unfreeze expect(lettings_log.prevten).to be 32
end
context "when the rent_type is Social Rent (0)" do end
let(:rent_type) { 0 }
it "derives and saves renttype and unitletas as Social rent(1)" do it "clears prevten if the log is marked as supported housing" do
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(needstype: 2)
expect(lettings_log.renttype).to eq(1) expect(lettings_log.prevten).to be nil
expect(record_from_db["renttype"]).to eq(1)
end end
it "derives and saves unitletas as Social rent(1)" do it "clears prevten if renewal is update to no" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to eq(1) expect(lettings_log.prevten).to be nil
expect(record_from_db["unitletas"]).to eq(1)
end end
end
context "and it is a 23/24 form" do context "and the managing organisation is a local authority" do
before do before do
Timecop.freeze(Time.zone.local(2023, 5, 1)) lettings_log.managing_organisation.update!(provider_type: "LA")
end lettings_log.update!(needstype: 1, renewal: 1)
end
after do it "correctly derives prevten" do
Timecop.unfreeze expect(lettings_log.prevten).to be 30
end
around do |example| end
Timecop.freeze(Time.zone.local(2023, 5, 1)) do
Singleton.__init__(FormHandler)
example.run
end
Timecop.return
Singleton.__init__(FormHandler)
end
it "derives and saves unitletas as Social rent(1)" do it "clears prevten if the log is marked as supported housing" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) lettings_log.update!(needstype: 2)
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] expect(lettings_log.prevten).to be nil
expect(lettings_log.unitletas).to eq(1) end
expect(record_from_db["unitletas"]).to eq(1)
end it "clears prevten if renewal is update to no" do
lettings_log.update!(renewal: 0)
expect(lettings_log.prevten).to be nil
end end
end end
end
context "when the rent_type is Affordable Rent(1)" do context "and updating rent_type" do
let(:rent_type) { 1 } let(:irproduct_other) { nil }
it "derives and saves renttype as Affordable Rent(2)" do around do |example|
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] Timecop.freeze(now) do
expect(lettings_log.renttype).to eq(2) Singleton.__init__(FormHandler)
expect(record_from_db["renttype"]).to eq(2) lettings_log.update!(rent_type:, irproduct_other:, startdate: now)
example.run
end end
end
it "derives and saves unitletas as Affordable Rent(2)" do context "when collection year is 2022/23 or earlier" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] let(:now) { Time.zone.local(2023, 1, 1) }
expect(lettings_log.unitletas).to eq(2)
expect(record_from_db["unitletas"]).to eq(2)
end
context "and it is a 23/24 form" do context "when rent_type is Social Rent" do
before do let(:rent_type) { 0 }
Timecop.freeze(Time.zone.local(2023, 5, 1))
end
after do it "derives the most recent let type as Social Rent basis if it is a renewal and clears it if it is not" do
Timecop.unfreeze lettings_log.update!(renewal: 1)
expect(lettings_log.unitletas).to be 1
lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end end
end
around do |example| context "when rent_type is Affordable Rent" do
Timecop.freeze(Time.zone.local(2023, 5, 1)) do let(:rent_type) { 1 }
Singleton.__init__(FormHandler)
example.run
end
Timecop.return
Singleton.__init__(FormHandler)
end
it "derives and saves unitletas as Affordable Rent basis(2)" do it "derives the most recent let type as Affordable Rent basis if it is a renewal and clears it if it is not" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) lettings_log.update!(renewal: 1)
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] expect(lettings_log.unitletas).to be 2
expect(lettings_log.unitletas).to eq(2) lettings_log.update!(renewal: 0)
expect(record_from_db["unitletas"]).to eq(2) expect(lettings_log.unitletas).to be nil
end end
end end
end
context "when the rent_type is London Affordable Rent(2)" do context "when rent_type is London Affordable Rent" do
let(:rent_type) { 2 } let(:rent_type) { 2 }
it "derives and saves renttype as London Affordable Rent(2)" do it "derives the most recent let type as Affordable Rent basis if it is a renewal and clears it if it is not" do
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(lettings_log.renttype).to eq(2) expect(lettings_log.unitletas).to be 2
expect(record_from_db["renttype"]).to eq(2) lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end
end end
it "derives and saves unitletas as London Affordable Rent(2)" do context "when rent_type is Rent to Buy" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] let(:rent_type) { 3 }
expect(lettings_log.unitletas).to eq(2)
expect(record_from_db["unitletas"]).to eq(2)
end
context "and it is a 23/24 form" do it "derives the most recent let type as Intermediate Rent basis if it is a renewal and clears it if it is not" do
before do lettings_log.update!(renewal: 1)
Timecop.freeze(Time.zone.local(2023, 5, 1)) expect(lettings_log.unitletas).to be 4
lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end end
end
after do context "when rent_type is London Living Rent" do
Timecop.unfreeze let(:rent_type) { 4 }
end
around do |example| it "derives the most recent let type as Intermediate Rent basis if it is a renewal and clears it if it is not" do
Timecop.freeze(Time.zone.local(2023, 5, 1)) do lettings_log.update!(renewal: 1)
Singleton.__init__(FormHandler) expect(lettings_log.unitletas).to be 4
example.run lettings_log.update!(renewal: 0)
end expect(lettings_log.unitletas).to be nil
Timecop.return
Singleton.__init__(FormHandler)
end end
end
it "derives and saves unitletas as London Affordable Rent basis(5)" do context "when rent_type is Other intermediate rent product" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) let(:rent_type) { 5 }
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] let(:irproduct_other) { "Rent first" }
expect(lettings_log.unitletas).to eq(5)
expect(record_from_db["unitletas"]).to eq(5) it "derives the most recent let type as Intermediate Rent basis if it is a renewal and clears it if it is not" do
lettings_log.update!(renewal: 1)
expect(lettings_log.unitletas).to be 4
lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end end
end end
end end
context "when the rent_type is Rent to Buy(3)" do context "when collection year is 2023/24 or later" do
let(:rent_type) { 3 } let(:now) { Time.zone.local(2024, 1, 1) }
it "derives and saves renttype as Intermediate Rent(3)" do context "when rent_type is Social Rent" do
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] let(:rent_type) { 0 }
expect(lettings_log.renttype).to eq(3)
expect(record_from_db["renttype"]).to eq(3)
end
it "derives and saves unitletas as Intermediate Rent(4)" do it "derives the most recent let type as Social Rent basis if it is a renewal and clears it if it is not" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(lettings_log.unitletas).to eq(4) expect(lettings_log.unitletas).to be 1
expect(record_from_db["unitletas"]).to eq(4) lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end
end end
context "and it is a 23/24 form" do context "when rent_type is Affordable Rent" do
before do let(:rent_type) { 1 }
Timecop.freeze(Time.zone.local(2023, 5, 1))
end
after do it "derives the most recent let type as Affordable Rent basis if it is a renewal and clears it if it is not" do
Timecop.unfreeze lettings_log.update!(renewal: 1)
expect(lettings_log.unitletas).to be 2
lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end end
end
around do |example| context "when rent_type is London Affordable Rent" do
Timecop.freeze(Time.zone.local(2023, 5, 1)) do let(:rent_type) { 2 }
Singleton.__init__(FormHandler)
example.run
end
Timecop.return
Singleton.__init__(FormHandler)
end
it "derives and saves unitletas as Rent to Buy basis(6)" do it "derives the most recent let type as London Affordable Rent basis if it is a renewal and clears it if it is not" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) lettings_log.update!(renewal: 1)
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] expect(lettings_log.unitletas).to be 5
expect(lettings_log.unitletas).to eq(6) lettings_log.update!(renewal: 0)
expect(record_from_db["unitletas"]).to eq(6) expect(lettings_log.unitletas).to be nil
end end
end end
end
context "when the rent_type is London Living Rent(4)" do context "when rent_type is Rent to Buy" do
let(:rent_type) { 4 } let(:rent_type) { 3 }
it "derives and saves renttype as Intermediate Rent(3)" do it "derives the most recent let type as Rent to Buy basis if it is a renewal and clears it if it is not" do
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(renewal: 1)
expect(lettings_log.renttype).to eq(3) expect(lettings_log.unitletas).to be 6
expect(record_from_db["renttype"]).to eq(3) lettings_log.update!(renewal: 0)
end expect(lettings_log.unitletas).to be nil
end
it "derives and saves unitletas as Intermediate Rent(4)" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0]
expect(lettings_log.unitletas).to eq(4)
expect(record_from_db["unitletas"]).to eq(4)
end end
context "and it is a 23/24 form" do context "when rent_type is London Living Rent" do
before do let(:rent_type) { 4 }
Timecop.freeze(Time.zone.local(2023, 5, 1))
end
after do it "derives the most recent let type as London Living Rent basis if it is a renewal and clears it if it is not" do
Timecop.unfreeze lettings_log.update!(renewal: 1)
expect(lettings_log.unitletas).to be 7
lettings_log.update!(renewal: 0)
expect(lettings_log.unitletas).to be nil
end end
end
around do |example| context "when rent_type is Other intermediate rent product" do
Timecop.freeze(Time.zone.local(2023, 5, 1)) do let(:rent_type) { 5 }
Singleton.__init__(FormHandler) let(:irproduct_other) { "Rent first" }
example.run
end
Timecop.return
Singleton.__init__(FormHandler)
end
it "derives and saves unitletas as London Living Rent basis(7)" do it "derives the most recent let type as Another Intermediate Rent basis if it is a renewal and clears it if it is not" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) lettings_log.update!(renewal: 1)
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] expect(lettings_log.unitletas).to be 8
expect(lettings_log.unitletas).to eq(7) lettings_log.update!(renewal: 0)
expect(record_from_db["unitletas"]).to eq(7) expect(lettings_log.unitletas).to be nil
end end
end end
end end
end
end
context "when the rent_type is Other intermediate rent product(5)" do context "when updating rent type" do
let(:rent_type) { 5 } let(:irproduct_other) { nil }
it "derives and saves renttype as Intermediate Rent(3)" do before do
record_from_db = ActiveRecord::Base.connection.execute("select renttype from lettings_logs where id=#{lettings_log.id}").to_a[0] lettings_log.update!(rent_type:, irproduct_other:)
expect(lettings_log.renttype).to eq(3) end
expect(record_from_db["renttype"]).to eq(3)
end
it "derives and saves unitletas as Intermediate Rent(4)" do context "when rent_type is Social Rent" do
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0] let(:rent_type) { 0 }
expect(lettings_log.unitletas).to eq(4)
expect(record_from_db["unitletas"]).to eq(4)
end
context "and it is a 23/24 form" do it "derives renttype as Social Rent" do
before do expect(lettings_log.renttype).to be 1
Timecop.freeze(Time.zone.local(2023, 5, 1)) end
end end
after do context "when rent_type is Affordable Rent" do
Timecop.unfreeze let(:rent_type) { 1 }
end
around do |example| it "derives renttype as Affordable Rent" do
Timecop.freeze(Time.zone.local(2023, 5, 1)) do expect(lettings_log.renttype).to be 2
Singleton.__init__(FormHandler) end
example.run end
end
Timecop.return
Singleton.__init__(FormHandler)
end
it "derives and saves unitletas as Other intermediate rent basis(8)" do context "when rent_type is London Affordable Rent" do
lettings_log.update!(startdate: Time.zone.local(2023, 5, 1)) let(:rent_type) { 2 }
record_from_db = ActiveRecord::Base.connection.execute("select unitletas from lettings_logs where id=#{lettings_log.id}").to_a[0]
expect(lettings_log.unitletas).to eq(8) it "derives renttype as Affordable Rent" do
expect(record_from_db["unitletas"]).to eq(8) expect(lettings_log.renttype).to be 2
end end
end end
context "when rent_type is Rent to Buy" do
let(:rent_type) { 3 }
it "derives renttype as Intermediate Rent" do
expect(lettings_log.renttype).to be 3
end
end
context "when rent_type is London Living Rent" do
let(:rent_type) { 4 }
it "derives renttype as Intermediate Rent" do
expect(lettings_log.renttype).to be 3
end
end
context "when rent_type is Other intermediate rent product" do
let(:rent_type) { 5 }
let(:irproduct_other) { "Rent first" }
it "derives renttype as Intermediate Rent" do
expect(lettings_log.renttype).to be 3
end end
end end
end end
@ -2339,6 +2343,7 @@ RSpec.describe LettingsLog do
end end
end end
# CHECK THROUGH
describe "resetting invalidated fields" do describe "resetting invalidated fields" do
let(:scheme) { create(:scheme, owning_organisation: created_by_user.organisation) } let(:scheme) { create(:scheme, owning_organisation: created_by_user.organisation) }
let!(:location) { create(:location, location_code: "E07000223", scheme:) } let!(:location) { create(:location, location_code: "E07000223", scheme:) }

Write Preview
Loading…
Cancel
Save