Browse Source
* Add delete confirmation page * Allow deleting scheme * Add delete scheme button and update policy * Add delete button to CYA * Update scheme policy * Do not display deleted schemes as an option * Add informative text for schemesrbe that have logs * Refactor query * Update testspull/2285/head
18 changed files with 494 additions and 10 deletions
@ -0,0 +1,24 @@ |
|||||||
|
<% content_for :before_content do %> |
||||||
|
<% content_for :title, "Are you sure you want to delete this scheme?" %> |
||||||
|
<%= govuk_back_link(href: :back) %> |
||||||
|
<% end %> |
||||||
|
|
||||||
|
<div class="govuk-grid-row"> |
||||||
|
<div class="govuk-grid-column-two-thirds-from-desktop"> |
||||||
|
<span class="govuk-caption-xl">Delete <%= @scheme.service_name %></span> |
||||||
|
<h1 class="govuk-heading-xl"> |
||||||
|
<%= content_for(:title) %> |
||||||
|
</h1> |
||||||
|
|
||||||
|
<%= govuk_warning_text(text: "You will not be able to undo this action.") %> |
||||||
|
|
||||||
|
<div class="govuk-button-group"> |
||||||
|
<%= govuk_button_to( |
||||||
|
"Delete this scheme", |
||||||
|
scheme_delete_path(@scheme), |
||||||
|
method: :delete, |
||||||
|
) %> |
||||||
|
<%= govuk_button_link_to "Cancel", scheme_path(@scheme), html: { method: :get }, secondary: true %> |
||||||
|
</div> |
||||||
|
</div> |
||||||
|
</div> |
||||||
@ -0,0 +1,5 @@ |
|||||||
|
class AddDiscardedAtColumnToSchemes < ActiveRecord::Migration[7.0] |
||||||
|
def change |
||||||
|
add_column :schemes, :discarded_at, :datetime |
||||||
|
end |
||||||
|
end |
||||||
@ -0,0 +1,94 @@ |
|||||||
|
require "rails_helper" |
||||||
|
|
||||||
|
RSpec.describe SchemePolicy do |
||||||
|
subject(:policy) { described_class } |
||||||
|
|
||||||
|
let(:data_provider) { create(:user, :data_provider) } |
||||||
|
let(:data_coordinator) { create(:user, :data_coordinator) } |
||||||
|
let(:support) { create(:user, :support) } |
||||||
|
|
||||||
|
permissions :delete? do |
||||||
|
let(:scheme) { create(:scheme) } |
||||||
|
|
||||||
|
before do |
||||||
|
create(:location, scheme:) |
||||||
|
end |
||||||
|
|
||||||
|
context "with active scheme" do |
||||||
|
it "does not allow deleting a scheme as a provider" do |
||||||
|
expect(policy).not_to permit(data_provider, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow allows deleting a scheme as a coordinator" do |
||||||
|
expect(policy).not_to permit(data_coordinator, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow deleting a scheme as a support user" do |
||||||
|
expect(policy).not_to permit(support, scheme) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "with incomplete scheme" do |
||||||
|
let(:scheme) { create(:scheme, :incomplete) } |
||||||
|
|
||||||
|
it "does not allow deleting a scheme as a provider" do |
||||||
|
expect(policy).not_to permit(data_provider, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow allows deleting a scheme as a coordinator" do |
||||||
|
expect(policy).not_to permit(data_coordinator, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "allows deleting a scheme as a support user" do |
||||||
|
expect(policy).to permit(support, scheme) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "with deactivated scheme" do |
||||||
|
before do |
||||||
|
scheme.scheme_deactivation_periods << create(:scheme_deactivation_period, deactivation_date: Time.zone.local(2024, 4, 10), scheme:) |
||||||
|
scheme.save! |
||||||
|
Timecop.freeze(Time.utc(2024, 4, 10)) |
||||||
|
log = create(:lettings_log, :sh, owning_organisation: scheme.owning_organisation, scheme:) |
||||||
|
log.startdate = Time.zone.local(2022, 10, 10) |
||||||
|
log.save!(validate: false) |
||||||
|
end |
||||||
|
|
||||||
|
after do |
||||||
|
Timecop.unfreeze |
||||||
|
end |
||||||
|
|
||||||
|
context "and associated logs in editable collection period" do |
||||||
|
before do |
||||||
|
create(:lettings_log, :sh, owning_organisation: scheme.owning_organisation, scheme:, startdate: Time.zone.local(2024, 4, 9)) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow deleting a scheme as a provider" do |
||||||
|
expect(policy).not_to permit(data_provider, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow allows deleting a scheme as a coordinator" do |
||||||
|
expect(policy).not_to permit(data_coordinator, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow deleting a scheme as a support user" do |
||||||
|
expect(policy).not_to permit(support, scheme) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "and no associated logs in editable collection period" do |
||||||
|
it "does not allow deleting a scheme as a provider" do |
||||||
|
expect(policy).not_to permit(data_provider, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "does not allow allows deleting a scheme as a coordinator" do |
||||||
|
expect(policy).not_to permit(data_coordinator, scheme) |
||||||
|
end |
||||||
|
|
||||||
|
it "allows deleting a scheme as a support user" do |
||||||
|
expect(policy).to permit(support, scheme) |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
Loading…
Reference in new issue