Browse Source

CLDC-2590 Add about this service section (#2124)

* Add about core section

* Move about core to the correct spot on start page

* Update content

* Add some margins
pull/2113/head
kosiakkatrina 2 years ago committed by GitHub
parent
commit
866db480cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      app/views/home/index.html.erb
  2. 7
      app/views/layouts/_about_this_service.html.erb
  3. 11
      app/views/start/index.html.erb
  4. 5
      spec/requests/start_controller_spec.rb

6
app/views/home/index.html.erb

@ -43,13 +43,15 @@
</div> </div>
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="app-data-box__underline"> <div class="app-data-box__underline">
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m"> <hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
</div> </div>
</div> </div>
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<%= render partial: "layouts/collection_resources" %> <%= render partial: "layouts/collection_resources" %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m"> <hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<%= render partial: "home/upcoming_deadlines" %> <%= render partial: "home/upcoming_deadlines" %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<%= render partial: "layouts/about_this_service" %>
</div> </div>
</div> </div>
</div> </div>

7
app/views/layouts/_about_this_service.html.erb

@ -0,0 +1,7 @@
<% if current_user.present? %>
<h1 class="govuk-heading-l govuk-!-width-two-thirds">About this service</h1>
<% else %>
<h2 class="govuk-heading-m govuk-!-width-two-thirds">About this service</h2>
<% end %>
<p class="govuk-body">Submit social housing lettings and sales data (CORE) is a service that collects information about every new social housing letting and sale in England. The data you submit is used to make decisions about funding, regulations, and policies.</p>
<p class="govuk-body"><%= govuk_link_to "Learn more about statistics on social housing lettings (opens in a new tab)", "https://www.gov.uk/government/collections/rents-lettings-and-tenancies", target: "_blank" %></p>

11
app/views/start/index.html.erb

@ -16,19 +16,16 @@
href: start_path, href: start_path,
) %> ) %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m"> <hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-bottom-8">
<h2 class="govuk-heading-m">Before you start</h2> <h2 class="govuk-heading-m">Before you start</h2>
<p class="govuk-body">Use your account details to sign in.</p> <p class="govuk-body">Use your account details to sign in.</p>
<p class="govuk-body">If you need to set up a new account, speak to your organisation’s CORE data coordinator. If you don’t know who that is, <%= govuk_link_to("contact the helpdesk", GlobalConstants::HELPDESK_URL) %>.</p> <p class="govuk-body">If you need to set up a new account, speak to your organisation’s CORE data coordinator. If you don’t know who that is, <%= govuk_link_to("contact the helpdesk", GlobalConstants::HELPDESK_URL) %>.</p>
<p class="govuk-body">You can <%= govuk_mail_to("dluhc.digital-services@levellingup.gov.uk", "request an account", subject: "CORE: Request a new account") %> if your organisation doesn’t have one.</p> <p class="govuk-body">You can <%= govuk_mail_to("dluhc.digital-services@levellingup.gov.uk", "request an account", subject: "CORE: Request a new account") %> if your organisation doesn’t have one.</p>
<p class="govuk-body"><strong><%= govuk_link_to guidance_path do %>Guidance for submitting social housing lettings and sales data (CORE)<% end %></strong><p> <p class="govuk-body"><strong><%= govuk_link_to guidance_path do %>Guidance for submitting social housing lettings and sales data (CORE)<% end %></strong><p>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m"> <hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
</div>
</div>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= render partial: "layouts/collection_resources" %> <%= render partial: "layouts/collection_resources" %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<%= render partial: "layouts/about_this_service" %>
</div> </div>
</div> </div>

5
spec/requests/start_controller_spec.rb

@ -60,6 +60,11 @@ RSpec.describe StartController, type: :request do
get "/", headers: headers, params: {} get "/", headers: headers, params: {}
expect(page).to have_content("Guidance for submitting social housing lettings and sales data (CORE)") expect(page).to have_content("Guidance for submitting social housing lettings and sales data (CORE)")
end end
it "displays About this service section" do
get "/", headers:, params: {}
expect(page).to have_content("About this service")
end
end end
end end

Loading…
Cancel
Save