Browse Source

lint and add new conditions to check answers for age1

pull/1077/head
Kat 4 years ago
parent
commit
852ac3a198
  1. 4
      app/models/form/question.rb
  2. 14
      app/models/form/sales/questions/age1.rb
  3. 3
      app/models/form/sales/questions/buyer1_age_known.rb
  4. 14
      spec/models/form/sales/questions/age1_spec.rb
  5. 17
      spec/models/form/sales/questions/buyer1_age_known_spec.rb

4
app/models/form/question.rb

@ -113,7 +113,7 @@ class Form::Question
return unless inferred_check_answers_value return unless inferred_check_answers_value
inferred_answer = inferred_check_answers_value.find { |inferred_value| inferred_value["condition"].values[0] == log[inferred_value["condition"].keys[0]] } inferred_answer = inferred_check_answers_value.find { |inferred_value| inferred_value["condition"].values[0] == log[inferred_value["condition"].keys[0]] }
inferred_answer.present?? inferred_answer["value"] : "" inferred_answer.present? ? inferred_answer["value"] : ""
end end
def displayed_answer_options(log, _current_user = nil) def displayed_answer_options(log, _current_user = nil)
@ -278,7 +278,7 @@ private
end end
def has_inferred_display_value?(log) def has_inferred_display_value?(log)
inferred_check_answers_value.present? && inferred_check_answers_value.any? { |inferred_value| log[inferred_value["condition"].keys.first] == inferred_value["condition"].values.first} inferred_check_answers_value.present? && inferred_check_answers_value.any? { |inferred_value| log[inferred_value["condition"].keys.first] == inferred_value["condition"].values.first }
end end
def checkbox_answer_label(log) def checkbox_answer_label(log)

14
app/models/form/sales/questions/age1.rb

@ -6,12 +6,16 @@ class Form::Sales::Questions::Age1 < ::Form::Question
@header = "Age" @header = "Age"
@type = "numeric" @type = "numeric"
@width = 2 @width = 2
@inferred_check_answers_value = [{ @inferred_check_answers_value = [
"condition" => { {
"age1_known" => 1, "condition" => { "age1_known" => 1 },
"value" => "Not known",
}, },
"value" => "Not known", {
}] "condition" => { "age1_known" => 2 },
"value" => "Prefers not to say",
},
]
@check_answers_card_number = 1 @check_answers_card_number = 1
end end
end end

3
app/models/form/sales/questions/buyer1_age_known.rb

@ -18,6 +18,9 @@ class Form::Sales::Questions::Buyer1AgeKnown < ::Form::Question
{ {
"age1_known" => 1, "age1_known" => 1,
}, },
{
"age1_known" => 2,
},
], ],
} }
@check_answers_card_number = 1 @check_answers_card_number = 1

14
spec/models/form/sales/questions/age1_spec.rb

@ -40,10 +40,16 @@ RSpec.describe Form::Sales::Questions::Age1, type: :model do
end end
it "has the correct inferred check answers value" do it "has the correct inferred check answers value" do
expect(question.inferred_check_answers_value).to eq([{ expect(question.inferred_check_answers_value).to eq([
"condition" => { "age1_known" => 1 }, {
"value" => "Not known", "condition" => { "age1_known" => 1 },
}]) "value" => "Not known",
},
{
"condition" => { "age1_known" => 2 },
"value" => "Prefers not to say",
},
])
end end
it "has the correct check_answers_card_number" do it "has the correct check_answers_card_number" do

17
spec/models/form/sales/questions/buyer1_age_known_spec.rb

@ -51,12 +51,17 @@ RSpec.describe Form::Sales::Questions::Buyer1AgeKnown, type: :model do
it "has correct hidden_in_check_answers for" do it "has correct hidden_in_check_answers for" do
expect(question.hidden_in_check_answers).to eq({ expect(question.hidden_in_check_answers).to eq({
"depends_on" => [{ "depends_on" => [
"age1_known" => 0, {
}, "age1_known" => 0,
{ },
"age1_known" => 1, {
}], "age1_known" => 1,
},
{
"age1_known" => 2,
},
],
}) })
end end

Loading…
Cancel
Save