Browse Source

Only process collections 2023 onwards

pull/1891/head
Kat 3 years ago
parent
commit
75603fb381
  1. 1
      app/services/imports/lettings_logs_field_import_service.rb
  2. 14
      spec/services/imports/lettings_logs_field_import_service_spec.rb

1
app/services/imports/lettings_logs_field_import_service.rb

@ -140,6 +140,7 @@ module Imports
old_id = meta_field_value(xml_doc, "document-id") old_id = meta_field_value(xml_doc, "document-id")
record = LettingsLog.find_by(old_id:) record = LettingsLog.find_by(old_id:)
return @logger.info("lettings log #{record.id} is from previous collection year, skipping") if record.collection_start_year < 2023
if record.present? if record.present?
if string_or_nil(xml_doc, "AddressLine1").present? && string_or_nil(xml_doc, "TownCity").present? if string_or_nil(xml_doc, "AddressLine1").present? && string_or_nil(xml_doc, "TownCity").present?

14
spec/services/imports/lettings_logs_field_import_service_spec.rb

@ -456,5 +456,19 @@ RSpec.describe Imports::LettingsLogsFieldImportService do
expect(lettings_log.is_la_inferred).to eq(false) expect(lettings_log.is_la_inferred).to eq(false)
end end
end end
context "when the lettings log is from before collection 23/24" do
let(:lettings_log_id) { "00d2343e-d5fa-4c89-8400-ec3854b0f2b4" }
let(:lettings_log) { LettingsLog.find_by(old_id: lettings_log_id) }
before do
lettings_log.update!(startdate: Time.zone.local(2022, 5, 5))
end
it "skips the update" do
expect(logger).to receive(:info).with(/lettings log #{lettings_log.id} is from previous collection year, skipping/)
import_service.send(:update_address, lettings_log_xml)
end
end
end end
end end

Loading…
Cancel
Save