From 75603fb38103d1f247017c7b8daea97368d358b8 Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 5 Sep 2023 16:41:47 +0100 Subject: [PATCH] Only process collections 2023 onwards --- .../imports/lettings_logs_field_import_service.rb | 1 + .../lettings_logs_field_import_service_spec.rb | 14 ++++++++++++++ 2 files changed, 15 insertions(+) diff --git a/app/services/imports/lettings_logs_field_import_service.rb b/app/services/imports/lettings_logs_field_import_service.rb index 47f96b589..14e530a76 100644 --- a/app/services/imports/lettings_logs_field_import_service.rb +++ b/app/services/imports/lettings_logs_field_import_service.rb @@ -140,6 +140,7 @@ module Imports old_id = meta_field_value(xml_doc, "document-id") record = LettingsLog.find_by(old_id:) + return @logger.info("lettings log #{record.id} is from previous collection year, skipping") if record.collection_start_year < 2023 if record.present? if string_or_nil(xml_doc, "AddressLine1").present? && string_or_nil(xml_doc, "TownCity").present? diff --git a/spec/services/imports/lettings_logs_field_import_service_spec.rb b/spec/services/imports/lettings_logs_field_import_service_spec.rb index fb29c8df9..66fd1573b 100644 --- a/spec/services/imports/lettings_logs_field_import_service_spec.rb +++ b/spec/services/imports/lettings_logs_field_import_service_spec.rb @@ -456,5 +456,19 @@ RSpec.describe Imports::LettingsLogsFieldImportService do expect(lettings_log.is_la_inferred).to eq(false) end end + + context "when the lettings log is from before collection 23/24" do + let(:lettings_log_id) { "00d2343e-d5fa-4c89-8400-ec3854b0f2b4" } + let(:lettings_log) { LettingsLog.find_by(old_id: lettings_log_id) } + + before do + lettings_log.update!(startdate: Time.zone.local(2022, 5, 5)) + end + + it "skips the update" do + expect(logger).to receive(:info).with(/lettings log #{lettings_log.id} is from previous collection year, skipping/) + import_service.send(:update_address, lettings_log_xml) + end + end end end