Browse Source

fix remove organisation

pull/1535/head
Kat 3 years ago
parent
commit
74386fc08b
  1. 2
      app/controllers/merge_requests_controller.rb
  2. 2
      app/views/merge_requests/organisations.html.erb
  3. 11
      spec/requests/merge_requests_controller_spec.rb

2
app/controllers/merge_requests_controller.rb

@ -36,7 +36,7 @@ class MergeRequestsController < ApplicationController
end
def remove_merging_organisation
MergeRequestOrganisation.find_by(merge_request_organisation_params).destroy!
MergeRequestOrganisation.find_by(merge_request_organisation_params)&.destroy!
@merge_request.reload
@answer_options = organisations_answer_options
@merging_organisations_list = [@merge_request.requesting_organisation] + @merge_request.merging_organisations

2
app/views/merge_requests/organisations.html.erb

@ -38,7 +38,7 @@
scope: "row",
class: "govuk-!-text-align-right",
}) do %>
<%= govuk_link_to("Remove", merge_request_organisations_path) %>
<%= govuk_link_to("Remove", merge_request_organisations_remove_path(merge_request: { merging_organisation: merging_organisation.id })) %>
<% end %>
<% end %>
<% end %>

11
spec/requests/merge_requests_controller_spec.rb

@ -151,6 +151,17 @@ RSpec.describe MergeRequestsController, type: :request do
expect(page).not_to have_link("Remove")
end
end
context "when removing an organisation that is not part of a merge from merge request" do
before do
get "/merge-request/#{merge_request.id}/organisations/remove", headers:, params:
end
it "does not throw an error" do
expect(merge_request.merging_organisations.count).to eq(0)
expect(page).not_to have_link("Remove")
end
end
end
describe "#other_merging_organisations" do

Loading…
Cancel
Save