Browse Source

CLDC-3245: Fix linter failures

pull/2271/head
Robert Sullivan 2 years ago
parent
commit
7143c11dc8
  1. 2
      app/models/derived_variables/sales_log_variables.rb
  2. 13
      spec/models/sales_log_spec.rb

2
app/models/derived_variables/sales_log_variables.rb

@ -4,7 +4,7 @@ module DerivedVariables::SalesLogVariables
def set_derived_fields! def set_derived_fields!
reset_invalidated_derived_values!(DEPENDENCIES) reset_invalidated_derived_values!(DEPENDENCIES)
self.pregblank = 1 if self.no_buyer_organisation? self.pregblank = 1 if no_buyer_organisation?
self.ethnic = 17 if ethnic_refused? self.ethnic = 17 if ethnic_refused?
self.mscharge = nil if no_monthly_leasehold_charges? self.mscharge = nil if no_monthly_leasehold_charges?
if exdate.present? if exdate.present?

13
spec/models/sales_log_spec.rb

@ -600,18 +600,19 @@ RSpec.describe SalesLog, type: :model do
end end
it "sets pregblank field when no buyer organisation is selected" do it "sets pregblank field when no buyer organisation is selected" do
expect { sales_log.update!( expect {
pregyrha: 0, sales_log.update!(pregyrha: 0,
pregla: 0, pregla: 0,
pregghb: 0, pregghb: 0,
pregother: 0) } pregother: 0)
.to change(sales_log, :pregblank).to 1 }.to change(sales_log, :pregblank).to 1
end end
%i[pregyrha pregla pregghb pregother].each do |field| %i[pregyrha pregla pregghb pregother].each do |field|
it "does not set pregblank field when #{field} is selected" do it "does not set pregblank field when #{field} is selected" do
expect { sales_log.update!({ field => 1, })} expect {
.not_to change(sales_log, :pregblank) sales_log.update!({ field => 1 })
}.not_to change(sales_log, :pregblank)
end end
end end
end end

Loading…
Cancel
Save