Refactor tests: change nesting

spec/services/imports/sales_logs_import_service_spec.rb

@@ -150,6 +150,46 @@ RSpec.describe Imports::SalesLogsImportService do
       end
     end
 
+    context "with shared ownership type" do
+      let(:sales_log_id) { shared_ownership_sales_log_id }
+
+      it "successfully creates a completed shared ownership log" do
+        allow(logger).to receive(:warn).and_return(nil)
+        sales_log_service.send(:create_log, sales_log_xml)
+
+        sales_log = SalesLog.find_by(old_id: sales_log_id)
+        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
+        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
+      end
+    end
+
+    context "with discounted ownership type" do
+      let(:sales_log_id) { discounted_ownership_sales_log_id }
+
+      it "successfully creates a completed discounted ownership log" do
+        allow(logger).to receive(:warn).and_return(nil)
+        sales_log_service.send(:create_log, sales_log_xml)
+
+        sales_log = SalesLog.find_by(old_id: sales_log_id)
+        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
+        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
+      end
+    end
+
+    context "with outright sale type" do
+      let(:sales_log_id) { outright_sale_sales_log_id }
+
+      it "successfully creates a completed outright sale log" do
+        allow(logger).to receive(:warn).and_return(nil)
+        sales_log_service.send(:create_log, sales_log_xml)
+
+        sales_log = SalesLog.find_by(old_id: sales_log_id)
+        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
+        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
+      end
+    end
+
+    context "when inferring default answers for completed sales logs" do
       context "when the armedforcesspouse is not answered" do
         let(:sales_log_id) { discounted_ownership_sales_log_id }
 
@@ -199,46 +239,14 @@ RSpec.describe Imports::SalesLogsImportService do
         end
       end
 
-    context "with shared ownership type" do
+      context "and it's an outright sale" do
-      let(:sales_log_id) { shared_ownership_sales_log_id }
-
-      it "successfully creates a completed shared ownership log" do
-        allow(logger).to receive(:warn).and_return(nil)
-        sales_log_service.send(:create_log, sales_log_xml)
-
-        sales_log = SalesLog.find_by(old_id: sales_log_id)
-        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
-        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
-      end
-    end
-
-    context "with discounted ownership type" do
-      let(:sales_log_id) { discounted_ownership_sales_log_id }
-
-      it "successfully creates a completed discounted ownership log" do
-        allow(logger).to receive(:warn).and_return(nil)
-        sales_log_service.send(:create_log, sales_log_xml)
-
-        sales_log = SalesLog.find_by(old_id: sales_log_id)
-        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
-        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
-      end
-    end
-
-    context "with outright sale type" do
         let(:sales_log_id) { outright_sale_sales_log_id }
 
-      it "successfully creates a completed outright sale log" do
+        before do
           allow(logger).to receive(:warn).and_return(nil)
-        sales_log_service.send(:create_log, sales_log_xml)
-
-        sales_log = SalesLog.find_by(old_id: sales_log_id)
-        applicable_questions = sales_log.form.subsections.map { |s| s.applicable_questions(sales_log) }.flatten
-        expect(applicable_questions.filter { |q| q.unanswered?(sales_log) }.map(&:id)).to be_empty
         end
 
-      it "infers mscharge_known as no, if it is not given" do
+        it "infers mscharge_known as no" do
-        allow(logger).to receive(:warn).and_return(nil)
           sales_log_service.send(:create_log, sales_log_xml)
 
           sales_log = SalesLog.find_by(old_id: sales_log_id)
@@ -246,4 +254,5 @@ RSpec.describe Imports::SalesLogsImportService do
         end
       end
     end
+  end
 end