baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Fix test

pull/2629/head
Manny Dinssa 2 years ago
parent
5ad923f9b5
commit
669a7d0b6f
2 changed files with 8 additions and 4 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 6
      spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb
  2. 6
      spec/services/bulk_upload/sales/year2024/row_parser_spec.rb

6
spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb
Unescape View File

@ -1444,10 +1444,11 @@ RSpec.describe BulkUpload::Lettings::Year2024::RowParser do
let(:affiliated_org) { create(:organisation, :with_old_visible_id) } let(:affiliated_org) { create(:organisation, :with_old_visible_id) }
let(:unaffiliated_user) { create(:user, organisation: create(:organisation)) } let(:unaffiliated_user) { create(:user, organisation: create(:organisation)) }
let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } } let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } }
let(:organisation_id) { unaffiliated_user.organisation_id }
before do before do
create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org) create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org)
bulk_upload.update!(organisation_id: affiliated_org.id, user: unaffiliated_user) bulk_upload.update!(organisation_id:, user: unaffiliated_user)
end end
it "blocks log creation and adds an error to field_1" do it "blocks log creation and adds an error to field_1" do
@ -1462,10 +1463,11 @@ RSpec.describe BulkUpload::Lettings::Year2024::RowParser do
let(:affiliated_org) { create(:organisation, :with_old_visible_id) } let(:affiliated_org) { create(:organisation, :with_old_visible_id) }
let(:unaffiliated_support_user) { create(:user, :support, organisation: create(:organisation)) } let(:unaffiliated_support_user) { create(:user, :support, organisation: create(:organisation)) }
let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } } let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } }
let(:organisation_id) { affiliated_org.id }
before do before do
create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org) create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org)
bulk_upload.update!(organisation_id: affiliated_org.id, user: unaffiliated_support_user) bulk_upload.update!(organisation_id:, user: unaffiliated_support_user)
end end
it "does not block log creation and does not add an error to field_1" do it "does not block log creation and does not add an error to field_1" do

6
spec/services/bulk_upload/sales/year2024/row_parser_spec.rb
Unescape View File

@ -559,10 +559,11 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do
let(:affiliated_org) { create(:organisation, :with_old_visible_id) } let(:affiliated_org) { create(:organisation, :with_old_visible_id) }
let(:unaffiliated_user) { create(:user, organisation: create(:organisation)) } let(:unaffiliated_user) { create(:user, organisation: create(:organisation)) }
let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } } let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } }
let(:organisation_id) { unaffiliated_user.organisation_id }
before do before do
create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org) create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org)
bulk_upload.update!(organisation_id: affiliated_org.id, user: unaffiliated_user) bulk_upload.update!(organisation_id:, user: unaffiliated_user)
end end
it "blocks log creation and adds an error to field_1" do it "blocks log creation and adds an error to field_1" do
@ -577,10 +578,11 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do
let(:affiliated_org) { create(:organisation, :with_old_visible_id) } let(:affiliated_org) { create(:organisation, :with_old_visible_id) }
let(:unaffiliated_support_user) { create(:user, :support, organisation: create(:organisation)) } let(:unaffiliated_support_user) { create(:user, :support, organisation: create(:organisation)) }
let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } } let(:attributes) { { bulk_upload:, field_1: affiliated_org.old_visible_id } }
let(:organisation_id) { affiliated_org.id }
before do before do
create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org) create(:organisation_relationship, parent_organisation: owning_org, child_organisation: affiliated_org)
bulk_upload.update!(organisation_id: affiliated_org.id, user: unaffiliated_support_user) bulk_upload.update!(organisation_id:, user: unaffiliated_support_user)
end end
it "does not block log creation and does not add an error to field_1" do it "does not block log creation and does not add an error to field_1" do

Write Preview
Loading…
Cancel
Save