Browse Source

Make sure field 12 as an error

pull/2053/head
Kat 3 years ago
parent
commit
5f948fc0bb
  1. 16
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  2. 8
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

16
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -329,6 +329,14 @@ class BulkUpload::Lettings::Year2023::RowParser
}, },
on: :after_log on: :after_log
validates :field_11,
presence: {
if: proc { renttype == :intermediate },
message: I18n.t("validations.not_answered", question: "intermediate rent type"),
category: :setup,
},
on: :after_log
validates :field_15, validates :field_15,
presence: { presence: {
if: proc { supported_housing? && log_uses_old_scheme_id? }, if: proc { supported_housing? && log_uses_old_scheme_id? },
@ -353,14 +361,6 @@ class BulkUpload::Lettings::Year2023::RowParser
}, },
on: :after_log on: :after_log
validates :field_11,
presence: {
if: proc { renttype == :intermediate },
message: I18n.t("validations.not_answered", question: "intermediate rent type"),
category: :setup,
},
on: :after_log
validates :field_46, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 1 must be a number or the letter R" }, on: :after_log validates :field_46, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 1 must be a number or the letter R" }, on: :after_log
validates :field_52, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 2 must be a number or the letter R" }, allow_blank: true, on: :after_log validates :field_52, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 2 must be a number or the letter R" }, allow_blank: true, on: :after_log
validates :field_56, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 3 must be a number or the letter R" }, allow_blank: true, on: :after_log validates :field_56, format: { with: /\A\d{1,3}\z|\AR\z/, message: "Age of person 3 must be a number or the letter R" }, allow_blank: true, on: :after_log

8
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -818,6 +818,14 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
end end
end end
context "when intermediate rent other and field_12 is not given" do
let(:attributes) { { bulk_upload:, field_5: "9", field_11: "3", field_12: nil } }
it "adds error on field_12" do
expect(parser.errors[:field_12]).to eq(["You must answer product name"])
end
end
context "when bulk upload is for general needs" do context "when bulk upload is for general needs" do
context "when general needs option selected" do context "when general needs option selected" do
let(:attributes) { { bulk_upload:, field_5: "1", field_4: "1" } } let(:attributes) { { bulk_upload:, field_5: "1", field_4: "1" } }

Loading…
Cancel
Save