Clean up lettings log property overrides

3 days ago · 5a2257272d
1 changed files with 8 additions and 10 deletions
--- a/app/models/lettings_log.rb
+++ b/app/models/lettings_log.rb
@ -184,19 +184,17 @@ class LettingsLog < Log
  end

  def la
-    if location && (!form.start_year_2026_or_later? || (form.start_year_2026_or_later? && !super))
+    return super unless location
+    return super if form.start_year_2026_or_later? && super
+
    location.linked_local_authorities.active(form.start_date).first&.code || location.location_code
-    else
-      super
-    end
  end

  def postcode_full
-    if location && (!form.start_year_2026_or_later? || (form.start_year_2026_or_later? && !super))
+    return super unless location
+    return super if form.start_year_2026_or_later? && super
+
    location.postcode
-    else
-      super
-    end
  end

  def postcode_full=(postcode)