Browse Source

setup errors always added

- no longer observes if the grouping already has errors
- as we have fine grain control in this class of how errors should be
pull/1377/head
Phil Lee 3 years ago
parent
commit
58baf8b45b
  1. 2
      app/services/bulk_upload/lettings/row_parser.rb
  2. 2
      spec/services/bulk_upload/lettings/row_parser_spec.rb

2
app/services/bulk_upload/lettings/row_parser.rb

@ -414,7 +414,7 @@ private
if setup_question?(question)
fields.each do |field|
unless errors.any? { |e| fields.include?(e.attribute) }
if errors[field].present?
errors.add(field, I18n.t("validations.not_answered", question: question.check_answer_label&.downcase), category: :setup)
end
end

2
spec/services/bulk_upload/lettings/row_parser_spec.rb

@ -218,7 +218,7 @@ RSpec.describe BulkUpload::Lettings::RowParser do
it "has errors on setup fields" do
errors = parser.errors.select { |e| e.options[:category] == :setup }.map(&:attribute)
expect(errors).to eql(%i[field_1 field_129 field_130 field_98 field_97 field_96 field_111 field_113])
expect(errors).to eql(%i[field_1 field_98 field_97 field_96 field_111 field_113])
end
end

Loading…
Cancel
Save