Browse Source

ensure that logs created via bulk upload have this set correctly when created

pull/1738/head
Arthur Campbell 3 years ago
parent
commit
4c73e0bb0f
  1. 1
      app/services/bulk_upload/lettings/log_creator.rb
  2. 1
      app/services/bulk_upload/sales/log_creator.rb
  3. 6
      spec/services/bulk_upload/lettings/log_creator_spec.rb
  4. 8
      spec/services/bulk_upload/sales/log_creator_spec.rb

1
app/services/bulk_upload/lettings/log_creator.rb

@ -14,6 +14,7 @@ class BulkUpload::Lettings::LogCreator
row_parser.log.blank_invalid_non_setup_fields! row_parser.log.blank_invalid_non_setup_fields!
row_parser.log.bulk_upload = bulk_upload row_parser.log.bulk_upload = bulk_upload
row_parser.log.creation_method = "bulk upload"
row_parser.log.skip_update_status = true row_parser.log.skip_update_status = true
row_parser.log.status = "pending" row_parser.log.status = "pending"
row_parser.log.status_cache = row_parser.log.calculate_status row_parser.log.status_cache = row_parser.log.calculate_status

1
app/services/bulk_upload/sales/log_creator.rb

@ -14,6 +14,7 @@ class BulkUpload::Sales::LogCreator
row_parser.log.blank_invalid_non_setup_fields! row_parser.log.blank_invalid_non_setup_fields!
row_parser.log.bulk_upload = bulk_upload row_parser.log.bulk_upload = bulk_upload
row_parser.log.creation_method = "bulk upload"
row_parser.log.skip_update_status = true row_parser.log.skip_update_status = true
row_parser.log.status = "pending" row_parser.log.status = "pending"
row_parser.log.status_cache = row_parser.log.calculate_status row_parser.log.status_cache = row_parser.log.calculate_status

6
spec/services/bulk_upload/lettings/log_creator_spec.rb

@ -27,6 +27,12 @@ RSpec.describe BulkUpload::Lettings::LogCreator do
expect(log.bulk_upload).to eql(bulk_upload) expect(log.bulk_upload).to eql(bulk_upload)
expect(bulk_upload.lettings_logs).to include(log) expect(bulk_upload.lettings_logs).to include(log)
end end
it "sets the creation method" do
service.call
expect(LettingsLog.last.creation_method).to eq "bulk upload"
end
end end
context "when a valid csv with several blank rows" do context "when a valid csv with several blank rows" do

8
spec/services/bulk_upload/sales/log_creator_spec.rb

@ -15,8 +15,6 @@ RSpec.describe BulkUpload::Sales::LogCreator do
Singleton.__init__(FormHandler) Singleton.__init__(FormHandler)
example.run example.run
end end
Timecop.return
Singleton.__init__(FormHandler)
end end
context "when a valid csv with new log" do context "when a valid csv with new log" do
@ -36,6 +34,12 @@ RSpec.describe BulkUpload::Sales::LogCreator do
expect(log.bulk_upload).to eql(bulk_upload) expect(log.bulk_upload).to eql(bulk_upload)
expect(bulk_upload.sales_logs).to include(log) expect(bulk_upload.sales_logs).to include(log)
end end
it "sets the creation method" do
service.call
expect(SalesLog.last.creation_method).to eq "bulk upload"
end
end end
context "when a valid csv with several blank rows" do context "when a valid csv with several blank rows" do

Loading…
Cancel
Save