Browse Source

feat: revert saledate/exdate work

pull/1225/head
natdeanlewissoftwire 3 years ago
parent
commit
4bc85c180e
  1. 34
      spec/models/validations/sales/sale_information_validations_spec.rb

34
spec/models/validations/sales/sale_information_validations_spec.rb

@ -5,62 +5,62 @@ RSpec.describe Validations::Sales::SaleInformationValidations do
let(:validator_class) { Class.new { include Validations::Sales::SaleInformationValidations } } let(:validator_class) { Class.new { include Validations::Sales::SaleInformationValidations } }
describe "#validate_practical_completion_date_before_exdate" do describe "#validate_practical_completion_date_before_saledate" do
context "when hodate blank" do context "when hodate blank" do
let(:record) { build(:sales_log, hodate: nil) } let(:record) { build(:sales_log, hodate: nil) }
it "does not add an error" do it "does not add an error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors).not_to be_present expect(record.errors).not_to be_present
end end
end end
context "when exdate blank" do context "when saledate blank" do
let(:record) { build(:sales_log, exdate: nil) } let(:record) { build(:sales_log, saledate: nil) }
it "does not add an error" do it "does not add an error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors).not_to be_present expect(record.errors).not_to be_present
end end
end end
context "when exdate and hodate blank" do context "when saledate and hodate blank" do
let(:record) { build(:sales_log, hodate: nil, exdate: nil) } let(:record) { build(:sales_log, hodate: nil, saledate: nil) }
it "does not add an error" do it "does not add an error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors).not_to be_present expect(record.errors).not_to be_present
end end
end end
context "when hodate before exdate" do context "when hodate before saledate" do
let(:record) { build(:sales_log, hodate: 2.months.ago, exdate: 1.month.ago) } let(:record) { build(:sales_log, hodate: 2.months.ago, saledate: 1.month.ago) }
it "does not add the error" do it "does not add the error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors).not_to be_present expect(record.errors).not_to be_present
end end
end end
context "when hodate after exdate" do context "when hodate after saledate" do
let(:record) { build(:sales_log, hodate: 1.month.ago, exdate: 2.months.ago) } let(:record) { build(:sales_log, hodate: 1.month.ago, saledate: 2.months.ago) }
it "adds error" do it "adds error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors[:hodate]).to be_present expect(record.errors[:hodate]).to be_present
end end
end end
context "when hodate == exdate" do context "when hodate == saledate" do
let(:record) { build(:sales_log, hodate: Time.zone.parse("2023-07-01"), exdate: Time.zone.parse("2023-07-01")) } let(:record) { build(:sales_log, hodate: Time.zone.parse("2023-07-01"), saledate: Time.zone.parse("2023-07-01")) }
it "does not add an error" do it "does not add an error" do
sale_information_validator.validate_practical_completion_date_before_exdate(record) sale_information_validator.validate_practical_completion_date_before_saledate(record)
expect(record.errors[:hodate]).to be_present expect(record.errors[:hodate]).to be_present
end end

Loading…
Cancel
Save