Browse Source

feat: use StringIOs in testing and fix row count bug found

pull/2018/head
natdeanlewissoftwire 3 years ago
parent
commit
49fda9dd16
  1. 2
      lib/tasks/correct_illness_from_csv.rake
  2. 8
      spec/lib/tasks/correct_address_from_csv_spec.rb
  3. 2
      spec/lib/tasks/correct_illness_from_csv_spec.rb

2
lib/tasks/correct_illness_from_csv.rake

@ -25,7 +25,7 @@ namespace :correct_illness do
illness_csv = CSV.parse(file_io, headers: true) illness_csv = CSV.parse(file_io, headers: true)
illness_csv.each_with_index do |row, index| illness_csv.each_with_index do |row, index|
next if index < 3 next if index < 2
lettings_log_id = row[1] lettings_log_id = row[1]

8
spec/lib/tasks/correct_address_from_csv_spec.rb

@ -91,11 +91,11 @@ RSpec.describe "data_import" do
before do before do
allow(storage_service).to receive(:get_file_io) allow(storage_service).to receive(:get_file_io)
.with("addresses_reimport_123.csv") .with("addresses_reimport_123.csv")
.and_return(replace_entity_ids(lettings_log, lettings_logs[0], lettings_logs[1], lettings_logs[2], File.open("./spec/fixtures/files/addresses_reimport.csv").read)) .and_return(StringIO.new(replace_entity_ids(lettings_log, lettings_logs[0], lettings_logs[1], lettings_logs[2], File.open("./spec/fixtures/files/addresses_reimport.csv").read)))
allow(storage_service).to receive(:get_file_io) allow(storage_service).to receive(:get_file_io)
.with("all_addresses_reimport_123.csv") .with("all_addresses_reimport_123.csv")
.and_return(replace_entity_ids(lettings_log, lettings_logs[0], lettings_logs[1], lettings_logs[2], File.open("./spec/fixtures/files/addresses_reimport_all_logs.csv").read)) .and_return(StringIO.new(replace_entity_ids(lettings_log, lettings_logs[0], lettings_logs[1], lettings_logs[2], File.open("./spec/fixtures/files/addresses_reimport_all_logs.csv").read)))
end end
context "when the file contains issue type column" do context "when the file contains issue type column" do
@ -312,11 +312,11 @@ RSpec.describe "data_import" do
before do before do
allow(storage_service).to receive(:get_file_io) allow(storage_service).to receive(:get_file_io)
.with("addresses_reimport_123.csv") .with("addresses_reimport_123.csv")
.and_return(replace_entity_ids(sales_log, sales_logs[0], sales_logs[1], sales_logs[2], File.open("./spec/fixtures/files/sales_addresses_reimport.csv").read)) .and_return(StringIO.new(replace_entity_ids(sales_log, sales_logs[0], sales_logs[1], sales_logs[2], File.open("./spec/fixtures/files/sales_addresses_reimport.csv").read)))
allow(storage_service).to receive(:get_file_io) allow(storage_service).to receive(:get_file_io)
.with("all_addresses_reimport_123.csv") .with("all_addresses_reimport_123.csv")
.and_return(replace_entity_ids(sales_log, sales_logs[0], sales_logs[1], sales_logs[2], File.open("./spec/fixtures/files/sales_addresses_reimport_all_logs.csv").read)) .and_return(StringIO.new(replace_entity_ids(sales_log, sales_logs[0], sales_logs[1], sales_logs[2], File.open("./spec/fixtures/files/sales_addresses_reimport_all_logs.csv").read)))
end end
context "when the file contains issue type column" do context "when the file contains issue type column" do

2
spec/lib/tasks/correct_illness_from_csv_spec.rb

@ -96,7 +96,7 @@ RSpec.describe "correct_illness" do
before do before do
allow(storage_service).to receive(:get_file_io) allow(storage_service).to receive(:get_file_io)
.with("illness_123.csv") .with("illness_123.csv")
.and_return(replace_entity_ids(lettings_log, second_lettings_log, third_lettings_log, File.open("./spec/fixtures/files/illness_update.csv").read)) .and_return(StringIO.new(replace_entity_ids(lettings_log, second_lettings_log, third_lettings_log, File.open("./spec/fixtures/files/illness_update.csv").read)))
end end
it "sets illness to yes and sets correct illness type" do it "sets illness to yes and sets correct illness type" do

Loading…
Cancel
Save