Rename old_template_path to legacy_template_path

app/models/forms/bulk_upload_lettings/guidance.rb

@@ -15,8 +15,8 @@ module Forms
         bulk_upload_lettings_log_path(id: "prepare-your-file", form: { year: })
       end
 
-      def old_template_path
+      def legacy_template_path
-        Forms::BulkUploadLettings::PrepareYourFile.new.old_template_path
+        Forms::BulkUploadLettings::PrepareYourFile.new.legacy_template_path
       end
 
       def template_path

app/models/forms/bulk_upload_lettings/prepare_your_file.rb

@@ -30,7 +30,7 @@ module Forms
         bulk_upload_lettings_log_path(id: page_id, form: { year:, needstype: })
       end
 
-      def old_template_path
+      def legacy_template_path
         case year
         when 2022
           "/files/bulk-upload-lettings-template-2022-23.xlsx"

app/models/forms/bulk_upload_sales/guidance.rb

@@ -15,8 +15,8 @@ module Forms
         bulk_upload_sales_log_path(id: "prepare-your-file", form: { year: })
       end
 
-      def old_template_path
+      def legacy_template_path
-        Forms::BulkUploadSales::PrepareYourFile.new.old_template_path
+        Forms::BulkUploadSales::PrepareYourFile.new.legacy_template_path
       end
 
       def template_path

app/models/forms/bulk_upload_sales/prepare_your_file.rb

@@ -28,7 +28,7 @@ module Forms
         bulk_upload_sales_log_path(id: "upload-your-file", form: { year: })
       end
 
-      def old_template_path
+      def legacy_template_path
         "/files/bulk-upload-sales-template-2022-23.xlsx"
       end
 

app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2023.html.erb

@@ -19,7 +19,7 @@
         </li>
 
         <li>
-          <%= govuk_link_to "Legacy template", @form.old_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end.
+          <%= govuk_link_to "Legacy template", @form.legacy_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end.
         </li>
       </ul>
 

app/views/bulk_upload_sales_logs/forms/prepare_your_file_2022.html.erb

@@ -12,7 +12,7 @@
 
       <h2 class="govuk-heading-s">Download template</h2>
       <ul class="govuk-list govuk-list--bullet">
-        <li>Download and use <%= govuk_link_to "this template", @form.old_template_path %>.</li>
+        <li>Download and use <%= govuk_link_to "this template", @form.legacy_template_path %>.</li>
       </ul>
 
       <h2 class="govuk-heading-s">Create your file</h2>

app/views/bulk_upload_sales_logs/forms/prepare_your_file_2023.html.erb

@@ -13,8 +13,8 @@
       <h2 class="govuk-heading-s">Download template</h2>
       <ul class="govuk-list govuk-list--bullet">
         <li><%= govuk_link_to "New template", @form.template_path %>: In this template, the questions are in the same order as the 2023/24 paper form and web form.</li>
-        <li><%= govuk_link_to "Legacy template", @form.old_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end.</li>
+        <li><%= govuk_link_to "Legacy template", @form.legacy_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end.</li>
-        <li>If your organisation was using bulk upload on the previous CORE website and hasn't changed its HMS to be compatible with the new CORE service, use <%= govuk_link_to "this template", @form.old_template_path %></li>
+        <li>If your organisation was using bulk upload on the previous CORE website and hasn't changed its HMS to be compatible with the new CORE service, use <%= govuk_link_to "this template", @form.legacy_template_path %></li>
       </ul>
 
       <h2 class="govuk-heading-s">Create your file</h2>

app/views/bulk_upload_shared/guidance.html.erb

@@ -59,7 +59,7 @@
         <%= govuk_details(summary_text: "How to choose the right template") do %>
           <p class="govuk-body">Use one of these templates to upload logs for 2023/24:</p>
           <p class="govuk-body"><%= govuk_link_to "New template", @form.template_path %>: In this template, the questions are in the same order as the 2023/24 paper form and web form. Use this template if your organisation is new to bulk upload or if your housing management system matches the new column ordering.</p>
-          <p class="govuk-body"><%= govuk_link_to "Legacy template", @form.old_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end. Use this template if you have not updated your system to match the new template yet.</p>
+          <p class="govuk-body"><%= govuk_link_to "Legacy template", @form.legacy_template_path %>: In this template, the questions are in the same order as the 2022/23 template, with new questions added on to the end. Use this template if you have not updated your system to match the new template yet.</p>
         <% end %>
       <% end %>
       <p class="govuk-body">If you still need support mapping data in the way we need, DLUHC’s helpdesk can help. If your data is across multiple systems, or is hard to export as a single file in the correct format, you could try different exports, or copy-pasting data by hand.</p>