Browse Source

set savings to not known if not given

pull/1331/head
Kat 3 years ago
parent
commit
449e388e12
  1. 1
      app/services/imports/sales_logs_import_service.rb
  2. 33
      spec/services/imports/sales_logs_import_service_spec.rb

1
app/services/imports/sales_logs_import_service.rb

@ -399,6 +399,7 @@ module Imports
def set_default_values(attributes)
attributes["mscharge_known"] ||= 0 if attributes["ownershipsch"] == 3
attributes["armedforcesspouse"] ||= 7
attributes["savingsnk"] ||= attributes["savings"].present? ? 0 : 1
end
end
end

33
spec/services/imports/sales_logs_import_service_spec.rb

@ -166,6 +166,39 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "when the savings not known is not answered and savings is not given" do
let(:sales_log_id) { discounted_ownership_sales_log_id }
before do
sales_log_xml.at_xpath("//xmlns:savingsKnown").content = ""
allow(logger).to receive(:warn).and_return(nil)
end
it "sets savingsnk to not know" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log&.savingsnk).to be(1)
end
end
context "when the savings not known is not answered and savings is given" do
let(:sales_log_id) { discounted_ownership_sales_log_id }
before do
sales_log_xml.at_xpath("//xmlns:Q3Savings").content = "10000"
sales_log_xml.at_xpath("//xmlns:savingsKnown").content = ""
allow(logger).to receive(:warn).and_return(nil)
end
it "sets savingsnk to know" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log&.savingsnk).to be(0)
end
end
context "with shared ownership type" do
let(:sales_log_id) { shared_ownership_sales_log_id }

Loading…
Cancel
Save