Browse Source

Address PO review

pull/1710/head
Jack S 3 years ago
parent
commit
385bd6eb14
  1. 2
      app/components/data_protection_confirmation_banner_component.html.erb
  2. 2
      app/components/data_protection_confirmation_banner_component.rb
  3. 1
      app/models/user.rb

2
app/components/data_protection_confirmation_banner_component.html.erb

@ -3,6 +3,6 @@
<p class="govuk-notification-banner__heading govuk-!-width-full" style="max-width: fit-content">
<%= header_text %>
<p>
<%= second_row %>
<%= banner_text %>
<% end %>
<% end %>

2
app/components/data_protection_confirmation_banner_component.rb

@ -30,7 +30,7 @@ class DataProtectionConfirmationBannerComponent < ViewComponent::Base
end
end
def second_row
def banner_text
if org_without_dpo? || user.is_dpo?
govuk_link_to(
link_text,

1
app/models/user.rb

@ -188,7 +188,6 @@ private
def send_data_protection_confirmation_reminder
return unless FeatureToggle.new_data_protection_confirmation?
return unless persisted?
return unless is_dpo_changed?
return unless is_dpo?
DataProtectionConfirmationMailer.send_confirmation_email(self).deliver_later

Loading…
Cancel
Save