Browse Source

This test seems flaky, likely because of the order, so reducing #of logs

pull/1915/head
Kat 3 years ago
parent
commit
374d9eaf5f
  1. 2
      spec/fixtures/files/imported_lettings_logs_missing_answers_report.csv
  2. 4
      spec/services/imports/import_report_service_spec.rb

2
spec/fixtures/files/imported_lettings_logs_missing_answers_report.csv vendored

@ -1,4 +1,4 @@
Missing answers,Total number of affected logs Missing answers,Total number of affected logs
age1_known,11 age1_known,10
beds,4 beds,4
"beds, age1_known",1 "beds, age1_known",1

1 Missing answers Total number of affected logs
2 age1_known 11 10
3 beds 4
4 beds, age1_known 1

4
spec/services/imports/import_report_service_spec.rb

@ -106,7 +106,7 @@ RSpec.describe Imports::ImportReportService do
let(:expected_answers_examples_content) { File.read("spec/fixtures/files/imported_lettings_logs_missing_answers_examples.csv") } let(:expected_answers_examples_content) { File.read("spec/fixtures/files/imported_lettings_logs_missing_answers_examples.csv") }
before do before do
create_list(:lettings_log, 11, :completed, age1_known: nil) do |log, i| create_list(:lettings_log, 10, :completed, age1_known: nil) do |log, i|
log.old_form_id = "100#{i}" log.old_form_id = "100#{i}"
log.old_id = "old_id_age1_known_#{i}" log.old_id = "old_id_age1_known_#{i}"
log.save! log.save!
@ -144,7 +144,7 @@ RSpec.describe Imports::ImportReportService do
let(:expected_answers_examples_content) { File.read("spec/fixtures/files/imported_lettings_logs_missing_answers_examples.csv") } let(:expected_answers_examples_content) { File.read("spec/fixtures/files/imported_lettings_logs_missing_answers_examples.csv") }
before do before do
create_list(:sales_log, 11, :completed, age1_known: nil) do |log, i| create_list(:sales_log, 10, :completed, age1_known: nil) do |log, i|
log.old_id = "old_id_age1_known_#{i}" log.old_id = "old_id_age1_known_#{i}"
log.old_form_id = "100#{i}" log.old_form_id = "100#{i}"
log.save! log.save!

Loading…
Cancel
Save