Browse Source

Mark logs as unresolved when scheme gets deactivated

pull/1035/head
Kat 4 years ago
parent
commit
33260dc0ea
  1. 2
      app/controllers/schemes_controller.rb
  2. 12
      spec/requests/schemes_controller_spec.rb

2
app/controllers/schemes_controller.rb

@ -349,6 +349,6 @@ private
end end
def reset_location_and_scheme_for_logs! def reset_location_and_scheme_for_logs!
@scheme.lettings_logs.filter_by_before_startdate(params[:deactivation_date].to_time).update!(location: nil, scheme: nil) @scheme.lettings_logs.filter_by_before_startdate(params[:deactivation_date].to_time).update!(location: nil, scheme: nil, unresolved: true)
end end
end end

12
spec/requests/schemes_controller_spec.rb

@ -1870,6 +1870,12 @@ RSpec.describe SchemesController, type: :request do
expect(lettings_log.scheme).to eq(nil) expect(lettings_log.scheme).to eq(nil)
expect(lettings_log.scheme).to eq(nil) expect(lettings_log.scheme).to eq(nil)
end end
it "marks log as needing attention" do
expect(lettings_log.unresolved).to eq(nil)
lettings_log.reload
expect(lettings_log.unresolved).to eq(true)
end
end end
context "and a log startdate is before scheme deactivation date" do context "and a log startdate is before scheme deactivation date" do
@ -1882,6 +1888,12 @@ RSpec.describe SchemesController, type: :request do
expect(lettings_log.scheme).to eq(scheme) expect(lettings_log.scheme).to eq(scheme)
expect(lettings_log.scheme).to eq(scheme) expect(lettings_log.scheme).to eq(scheme)
end end
it "does not mark log as needing attention" do
expect(lettings_log.unresolved).to eq(nil)
lettings_log.reload
expect(lettings_log.unresolved).to eq(nil)
end
end end
end end

Loading…
Cancel
Save