From 33260dc0eac9e9b4ff15afe76e5c7e64bbd19010 Mon Sep 17 00:00:00 2001 From: Kat Date: Fri, 25 Nov 2022 15:52:50 +0000 Subject: [PATCH] Mark logs as unresolved when scheme gets deactivated --- app/controllers/schemes_controller.rb | 2 +- spec/requests/schemes_controller_spec.rb | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/app/controllers/schemes_controller.rb b/app/controllers/schemes_controller.rb index 389446b7f..153a81924 100644 --- a/app/controllers/schemes_controller.rb +++ b/app/controllers/schemes_controller.rb @@ -349,6 +349,6 @@ private end def reset_location_and_scheme_for_logs! - @scheme.lettings_logs.filter_by_before_startdate(params[:deactivation_date].to_time).update!(location: nil, scheme: nil) + @scheme.lettings_logs.filter_by_before_startdate(params[:deactivation_date].to_time).update!(location: nil, scheme: nil, unresolved: true) end end diff --git a/spec/requests/schemes_controller_spec.rb b/spec/requests/schemes_controller_spec.rb index 0769e15c6..feef2f762 100644 --- a/spec/requests/schemes_controller_spec.rb +++ b/spec/requests/schemes_controller_spec.rb @@ -1870,6 +1870,12 @@ RSpec.describe SchemesController, type: :request do expect(lettings_log.scheme).to eq(nil) expect(lettings_log.scheme).to eq(nil) end + + it "marks log as needing attention" do + expect(lettings_log.unresolved).to eq(nil) + lettings_log.reload + expect(lettings_log.unresolved).to eq(true) + end end context "and a log startdate is before scheme deactivation date" do @@ -1882,6 +1888,12 @@ RSpec.describe SchemesController, type: :request do expect(lettings_log.scheme).to eq(scheme) expect(lettings_log.scheme).to eq(scheme) end + + it "does not mark log as needing attention" do + expect(lettings_log.unresolved).to eq(nil) + lettings_log.reload + expect(lettings_log.unresolved).to eq(nil) + end end end