baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

refactor: simplify no errors tests

pull/1404/head
Sam Seed 3 years ago
parent
fa433015a9
commit
323ac76f5a
1 changed files with 8 additions and 16 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 24
      spec/models/validations/sales/financial_validations_spec.rb

24
spec/models/validations/sales/financial_validations_spec.rb
Unescape View File

@ -222,52 +222,44 @@ RSpec.describe Validations::Sales::FinancialValidations do
record.type = 2 record.type = 2
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 16 record.type = 16
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 18 record.type = 18
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 24 record.type = 24
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.stairbought = 1 record.stairbought = 1
record.type = 28 record.type = 28
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 30 record.type = 30
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 31 record.type = 31
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
record.type = 32 record.type = 32
financial_validator.validate_percentage_bought_at_least_threshold(record) financial_validator.validate_percentage_bought_at_least_threshold(record)
expect(record.errors["stairbought"]).to be_empty expect(record.errors).to be_empty
expect(record.errors["type"]).to be_empty
record.errors.clear record.errors.clear
end end
end end

Write Preview
Loading…
Cancel
Save