From 323ac76f5a910f501e2067e1ec669e8c944b1527 Mon Sep 17 00:00:00 2001
From: Sam Seed <sam.seed@softwire.com>
Date: Tue, 14 Mar 2023 10:55:21 +0000
Subject: [PATCH] refactor: simplify no errors tests

---
 .../sales/financial_validations_spec.rb       | 24 +++++++------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/spec/models/validations/sales/financial_validations_spec.rb b/spec/models/validations/sales/financial_validations_spec.rb
index 55d6e3c52..b922228f7 100644
--- a/spec/models/validations/sales/financial_validations_spec.rb
+++ b/spec/models/validations/sales/financial_validations_spec.rb
@@ -222,52 +222,44 @@ RSpec.describe Validations::Sales::FinancialValidations do
 
       record.type = 2
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 16
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 18
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 24
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.stairbought = 1
 
       record.type = 28
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 30
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 31
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
 
       record.type = 32
       financial_validator.validate_percentage_bought_at_least_threshold(record)
-      expect(record.errors["stairbought"]).to be_empty
-      expect(record.errors["type"]).to be_empty
+      expect(record.errors).to be_empty
       record.errors.clear
     end
   end