baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Update check answers card headers

pull/1249/head
Kat 3 years ago
parent
4568faa16c
commit
29009c2482
3 changed files with 12 additions and 8 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      app/components/check_answers_summary_list_card_component.rb
  2. 8
      spec/factories/sales_log.rb
  3. 10
      spec/features/form/check_answers_page_sales_logs_spec.rb

2
app/components/check_answers_summary_list_card_component.rb
Unescape View File

@ -30,7 +30,7 @@ class CheckAnswersSummaryListCardComponent < ViewComponent::Base
when 1..number_of_buyers when 1..number_of_buyers
"Buyer #{question.check_answers_card_number}" "Buyer #{question.check_answers_card_number}"
when (number_of_buyers + 1)..(number_of_buyers + 4) when (number_of_buyers + 1)..(number_of_buyers + 4)
"Person #{question.check_answers_card_number - number_of_buyers}" "Person #{question.check_answers_card_number}"
end end
end end
end end

8
spec/factories/sales_log.rb
Unescape View File

@ -38,16 +38,16 @@ FactoryBot.define do
ecstat2 { "1" } ecstat2 { "1" }
hholdcount { "1" } hholdcount { "1" }
wheel { 1 } wheel { 1 }
details_known_1 { 1 } details_known_3 { 1 }
age3_known { 0 } age3_known { 0 }
age3 { 14 } age3 { 14 }
details_known_2 { 1 } details_known_4 { 1 }
age4_known { 0 } age4_known { 0 }
age4 { 18 } age4 { 18 }
details_known_3 { 1 } details_known_5 { 1 }
age5_known { 0 } age5_known { 0 }
age5 { 40 } age5 { 40 }
details_known_4 { 1 } details_known_6 { 1 }
age6_known { 0 } age6_known { 0 }
age6 { 40 } age6 { 40 }
income1nk { 0 } income1nk { 0 }

10
spec/features/form/check_answers_page_sales_logs_spec.rb
Unescape View File

@ -43,8 +43,10 @@ RSpec.describe "Sales Log Check Answers Page" do
visit("/sales-logs/#{completed_sales_log_joint_purchase.id}/#{subsection}/check-answers") visit("/sales-logs/#{completed_sales_log_joint_purchase.id}/#{subsection}/check-answers")
assert_selector ".x-govuk-summary-card__title", text: "Buyer 1", count: 1 assert_selector ".x-govuk-summary-card__title", text: "Buyer 1", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Buyer 2", count: 1 assert_selector ".x-govuk-summary-card__title", text: "Buyer 2", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Person 1", count: 1 assert_selector ".x-govuk-summary-card__title", text: "Person 1", count: 0
assert_selector ".x-govuk-summary-card__title", text: "Person 2", count: 0 assert_selector ".x-govuk-summary-card__title", text: "Person 2", count: 0
assert_selector ".x-govuk-summary-card__title", text: "Person 3", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Person 4", count: 1
end end
end end
@ -53,8 +55,10 @@ RSpec.describe "Sales Log Check Answers Page" do
visit("/sales-logs/#{completed_sales_log_non_joint_purchase.id}/#{subsection}/check-answers") visit("/sales-logs/#{completed_sales_log_non_joint_purchase.id}/#{subsection}/check-answers")
assert_selector ".x-govuk-summary-card__title", text: "Buyer 1", count: 1 assert_selector ".x-govuk-summary-card__title", text: "Buyer 1", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Buyer 2", count: 0 assert_selector ".x-govuk-summary-card__title", text: "Buyer 2", count: 0
assert_selector ".x-govuk-summary-card__title", text: "Person 1", count: 1 assert_selector ".x-govuk-summary-card__title", text: "Person 1", count: 0
assert_selector ".x-govuk-summary-card__title", text: "Person 2", count: 0 assert_selector ".x-govuk-summary-card__title", text: "Person 2", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Person 3", count: 1
assert_selector ".x-govuk-summary-card__title", text: "Person 4", count: 1
end end
end end
end end

Write Preview
Loading…
Cancel
Save