feat: use needstype helpers and test tweak

app/services/bulk_upload/lettings/year2023/row_parser.rb

@@ -868,8 +868,8 @@ private
       errors.add(:field_8, error_message) # startdate
       errors.add(:field_9, error_message) # startdate
       errors.add(:field_13, error_message) # tenancycode
-      errors.add(location_field, error_message) unless general_needs? && location_field.present? # location
+      errors.add(location_field, error_message) if !general_needs? && location_field.present? # location
-      errors.add(:field_16, error_message) unless general_needs? && location_field.blank? # add to Scheme field as unclear whether log uses New or Old CORE ids
+      errors.add(:field_16, error_message) if !general_needs? && location_field.blank? # add to Scheme field as unclear whether log uses New or Old CORE ids
       errors.add(:field_23, error_message) unless supported_housing? # postcode_full
       errors.add(:field_24, error_message) unless supported_housing? # postcode_full
       errors.add(:field_25, error_message) unless supported_housing? # la

spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
       bulk_upload:,
       field_1: owning_org.old_visible_id,
       field_2: managing_org.old_visible_id,
-      field_4: "1",
+      field_4: "2",
       field_5: "2",
       field_6: "2",
       field_7: now.day.to_s,