Browse Source

feat: remove redundant user instance variable

pull/2083/head
natdeanlewissoftwire 2 years ago
parent
commit
2484b8f8af
  1. 2
      app/jobs/scheme_email_csv_job.rb
  2. 3
      app/services/csv/scheme_csv_service.rb

2
app/jobs/scheme_email_csv_job.rb

@ -8,7 +8,7 @@ class SchemeEmailCsvJob < ApplicationJob
def perform(user, search_term = nil, filters = {}, all_orgs = false, organisation = nil, download_type = "combined") # rubocop:disable Style/OptionalBooleanParameter - sidekiq can't serialise named params
unfiltered_schemes = organisation.present? && user.support? ? Scheme.where(owning_organisation_id: organisation.id) : user.schemes
filtered_schemes = FilterManager.filter_schemes(unfiltered_schemes, search_term, filters, all_orgs, user)
csv_string = Csv::SchemeCsvService.new(user:, download_type:).prepare_csv(filtered_schemes)
csv_string = Csv::SchemeCsvService.new(download_type:).prepare_csv(filtered_schemes)
case download_type
when "schemes"

3
app/services/csv/scheme_csv_service.rb

@ -3,8 +3,7 @@ module Csv
include SchemesHelper
include LocationsHelper
def initialize(user:, download_type:)
@user = user
def initialize(download_type:)
@download_type = download_type
end

Loading…
Cancel
Save