Browse Source

Remove ecstat if the income is too high for it

pull/1463/head
Kat 3 years ago
parent
commit
18ba167054
  1. 5
      app/services/imports/lettings_logs_import_service.rb
  2. 23
      spec/services/imports/lettings_logs_import_service_spec.rb

5
app/services/imports/lettings_logs_import_service.rb

@ -327,6 +327,11 @@ module Imports
@logs_overridden << lettings_log.old_id @logs_overridden << lettings_log.old_id
attributes.delete("offered") attributes.delete("offered")
save_lettings_log(attributes, previous_status) save_lettings_log(attributes, previous_status)
elsif lettings_log.errors.of_kind?(:earnings, :over_hard_max)
@logger.warn("Log #{lettings_log.old_id}: Removing working situation because income is too high for it")
@logs_overridden << lettings_log.old_id
attributes.delete("ecstat1")
save_lettings_log(attributes, previous_status)
else else
@logger.error("Log #{lettings_log.old_id}: Failed to import") @logger.error("Log #{lettings_log.old_id}: Failed to import")
lettings_log.errors.each do |error| lettings_log.errors.each do |error|

23
spec/services/imports/lettings_logs_import_service_spec.rb

@ -418,6 +418,29 @@ RSpec.describe Imports::LettingsLogsImportService do
end end
end end
context "and income over the max" do
before do
lettings_log_xml.at_xpath("//xmlns:Q8Money").content = "25000"
end
it "intercepts the relevant validation error" do
expect(logger).to receive(:warn).with(/Removing working situation because income is too high for it/)
expect { lettings_log_service.send(:create_log, lettings_log_xml) }
.not_to raise_error
end
it "clears out the referral answer" do
allow(logger).to receive(:warn)
lettings_log_service.send(:create_log, lettings_log_xml)
lettings_log = LettingsLog.find_by(old_id: lettings_log_id)
expect(lettings_log).not_to be_nil
expect(lettings_log.ecstat1).to be_nil
expect(lettings_log.earnings).to eq(25_000)
end
end
context "and the net income soft validation is triggered (net_income_value_check)" do context "and the net income soft validation is triggered (net_income_value_check)" do
before do before do
lettings_log_xml.at_xpath("//xmlns:Q8a").content = "1 Weekly" lettings_log_xml.at_xpath("//xmlns:Q8a").content = "1 Weekly"

Loading…
Cancel
Save