feat: further simplify unpend_and_confirm_soft_validations

app/models/bulk_upload.rb

@@ -84,18 +84,12 @@ class BulkUpload < ApplicationRecord
 
   def unpend_and_confirm_soft_validations
     logs.find_each do |log|
-      SHARED_VALUE_CHECKS.each do |field|
+      fields_to_confirm = SHARED_VALUE_CHECKS + (if log.lettings?
-        log[field] = 0
+                                                   LETTINGS_VALUE_CHECKS
-      end
+                                                 elsif log.sales?
-      if log.lettings?
+                                                   SALES_VALUE_CHECKS
-        LETTINGS_VALUE_CHECKS.each do |field|
+                                                 end)
-          log[field] = 0
+      fields_to_confirm.each { |field| log[field] = 0 }
-        end
-      elsif log.sales?
-        SALES_VALUE_CHECKS.each do |field|
-          log[field] = 0
-        end
-      end
       log.save!
     end
   end