From 1847120fb3392c1a8fb31837ffa8da858b89a8af Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Tue, 27 Feb 2024 14:43:51 +0000
Subject: [PATCH] feat: further simplify unpend_and_confirm_soft_validations

---
 app/models/bulk_upload.rb | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/app/models/bulk_upload.rb b/app/models/bulk_upload.rb
index ba08398e1..2c8b7cf5e 100644
--- a/app/models/bulk_upload.rb
+++ b/app/models/bulk_upload.rb
@@ -84,18 +84,12 @@ class BulkUpload < ApplicationRecord
 
   def unpend_and_confirm_soft_validations
     logs.find_each do |log|
-      SHARED_VALUE_CHECKS.each do |field|
-        log[field] = 0
-      end
-      if log.lettings?
-        LETTINGS_VALUE_CHECKS.each do |field|
-          log[field] = 0
-        end
-      elsif log.sales?
-        SALES_VALUE_CHECKS.each do |field|
-          log[field] = 0
-        end
-      end
+      fields_to_confirm = SHARED_VALUE_CHECKS + (if log.lettings?
+                                                   LETTINGS_VALUE_CHECKS
+                                                 elsif log.sales?
+                                                   SALES_VALUE_CHECKS
+                                                 end)
+      fields_to_confirm.each { |field| log[field] = 0 }
       log.save!
     end
   end