Browse Source

Fix the retirement check showing on the card 8, fix tests

pull/1584/head
Kat 3 years ago
parent
commit
119b6590c9
  1. 2
      app/models/form/lettings/pages/lead_tenant_over_retirement_value_check.rb
  2. 2
      app/models/form/lettings/pages/lead_tenant_under_retirement_value_check.rb
  3. 2
      app/models/form/lettings/pages/person_over_retirement_value_check.rb
  4. 2
      app/models/form/lettings/pages/person_under_retirement_value_check.rb
  5. 6
      app/models/form/lettings/questions/no_retirement_value_check.rb
  6. 6
      app/models/form/lettings/questions/retirement_value_check.rb
  7. 4
      spec/models/form/lettings/pages/net_income_value_check_spec.rb

2
app/models/form/lettings/pages/lead_tenant_over_retirement_value_check.rb

@ -27,7 +27,7 @@ class Form::Lettings::Pages::LeadTenantOverRetirementValueCheck < ::Form::Page
end
def questions
@questions ||= [Form::Lettings::Questions::RetirementValueCheck.new(nil, nil, self)]
@questions ||= [Form::Lettings::Questions::RetirementValueCheck.new(nil, nil, self, person_index: 1)]
end
def interruption_screen_question_ids

2
app/models/form/lettings/pages/lead_tenant_under_retirement_value_check.rb

@ -17,7 +17,7 @@ class Form::Lettings::Pages::LeadTenantUnderRetirementValueCheck < ::Form::Page
end
def questions
@questions ||= [Form::Lettings::Questions::NoRetirementValueCheck.new(nil, nil, self)]
@questions ||= [Form::Lettings::Questions::NoRetirementValueCheck.new(nil, nil, self, person_index: 1)]
end
def interruption_screen_question_ids

2
app/models/form/lettings/pages/person_over_retirement_value_check.rb

@ -32,7 +32,7 @@ class Form::Lettings::Pages::PersonOverRetirementValueCheck < ::Form::Page
end
def questions
@questions ||= [Form::Lettings::Questions::RetirementValueCheck.new(nil, nil, self)]
@questions ||= [Form::Lettings::Questions::RetirementValueCheck.new(nil, nil, self, person_index: @person_index)]
end
def interruption_screen_question_ids

2
app/models/form/lettings/pages/person_under_retirement_value_check.rb

@ -18,7 +18,7 @@ class Form::Lettings::Pages::PersonUnderRetirementValueCheck < ::Form::Page
end
def questions
@questions ||= [Form::Lettings::Questions::NoRetirementValueCheck.new(nil, nil, self)]
@questions ||= [Form::Lettings::Questions::NoRetirementValueCheck.new(nil, nil, self, person_index: @person_index)]
end
def interruption_screen_question_ids

6
app/models/form/lettings/questions/no_retirement_value_check.rb

@ -1,11 +1,11 @@
class Form::Lettings::Questions::NoRetirementValueCheck < ::Form::Question
def initialize(id, hsh, page)
super
def initialize(id, hsh, page, person_index:)
super(id, hsh, page)
@id = "retirement_value_check"
@check_answer_label = "Retirement confirmation"
@header = "Are you sure this person is retired?"
@type = "interruption_screen"
@check_answers_card_number = 8
@check_answers_card_number = person_index
@answer_options = ANSWER_OPTIONS
@hidden_in_check_answers = {
"depends_on" => [

6
app/models/form/lettings/questions/retirement_value_check.rb

@ -1,11 +1,11 @@
class Form::Lettings::Questions::RetirementValueCheck < ::Form::Question
def initialize(id, hsh, page)
super
def initialize(id, hsh, page, person_index:)
super(id, hsh, page)
@id = "retirement_value_check"
@check_answer_label = "Retirement confirmation"
@header = "Are you sure this person isn’t retired?"
@type = "interruption_screen"
@check_answers_card_number = 8
@check_answers_card_number = person_index
@answer_options = ANSWER_OPTIONS
@hidden_in_check_answers = {
"depends_on" => [

4
spec/models/form/lettings/pages/net_income_value_check_spec.rb

@ -28,12 +28,12 @@ RSpec.describe Form::Lettings::Pages::NetIncomeValueCheck, type: :model do
end
it "has the correct title_text" do
expect(page.title_text).to eq({ "translation" => "soft_validations.net_income.title_text" })
expect(page.title_text).to eq({ "translation" => "soft_validations.net_income.title_text", "arguments" => [{ "i18n_template" => "incfreq", "key" => "incfreq", "label" => true }, { "arguments_for_key" => "earnings", "i18n_template" => "earnings", "key" => "field_formatted_as_currency" }] })
end
it "has the correct informative_text" do
expect(page.informative_text).to eq({
"arguments" => [{ "label" => true, "i18n_template" => "ecstat1", "key" => "ecstat1" }, { "arguments_for_key" => "earnings", "i18n_template" => "earnings", "key" => "field_formatted_as_currency" }],
"arguments" => [{ "i18n_template" => "net_income_higher_or_lower_text", "key" => "net_income_higher_or_lower_text", "label" => false }],
"translation" => "soft_validations.net_income.hint_text",
})
end

Loading…
Cancel
Save