Browse Source

CLDC-4270: Fix tests post merge

CLDC-4270-fix-text-being-coerced-to-0-on-integer-fields
samyou-softwire 2 days ago
parent
commit
09af58c785
  1. 2
      app/services/bulk_upload/sales/year2025/row_parser.rb
  2. 6
      spec/services/bulk_upload/sales/year2026/csv_parser_spec.rb
  3. 8
      spec/services/bulk_upload/sales/year2026/row_parser_spec.rb

2
app/services/bulk_upload/sales/year2025/row_parser.rb

@ -288,7 +288,7 @@ class BulkUpload::Sales::Year2025::RowParser
attribute :field_112, :integer
attribute :field_113, :decimal
attribute :field_114, :integer
attribute :field_114, :decimal
attribute :field_115, :decimal
attribute :field_116, :integer
attribute :field_117, :decimal

6
spec/services/bulk_upload/sales/year2026/csv_parser_spec.rb

@ -195,8 +195,8 @@ RSpec.describe BulkUpload::Sales::Year2026::CsvParser do
let(:field_values) { log_to_csv.to_2026_row }
before do
field_32_index = field_numbers.index(32)
field_values[field_32_index] = "abc" # should be an integer
field_34_index = field_numbers.index(34)
field_values[field_34_index] = "abc" # should be an integer
file.write(log_to_csv.custom_field_numbers_row(field_numbers:))
file.write(log_to_csv.to_custom_csv_row(field_values:))
@ -204,7 +204,7 @@ RSpec.describe BulkUpload::Sales::Year2026::CsvParser do
end
it "sets the invalid data to nil" do
expect(service.row_parsers[0].field_32).to be_nil
expect(service.row_parsers[0].field_34).to be_nil
end
end
end

8
spec/services/bulk_upload/sales/year2026/row_parser_spec.rb

@ -344,17 +344,17 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do
end
describe "invalid fields" do
let(:attributes) { setup_section_params.merge({ field_31: 0 }) }
let(:attributes) { setup_section_params.merge({ field_34: 0 }) }
context "when a field has been marked as invalid" do
before do
parser.add_invalid_field("field_31")
parser.add_invalid_field("field_34")
end
it "sets a single error on that field" do
parser.valid?
expect(parser.errors[:field_31].size).to eq(1)
expect(parser.errors[:field_31]).to include(match(I18n.t("validations.sales.2026.bulk_upload.invalid_option", question: "What is buyer 1s nationality?")))
expect(parser.errors[:field_34].size).to eq(1)
expect(parser.errors[:field_34]).to include(match(I18n.t("validations.sales.2026.bulk_upload.invalid_option", question: "What is buyer 1's nationality?")))
end
end
end

Loading…
Cancel
Save