From d415a7c8c3951afb15209b21f33d9371cc0beec5 Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Tue, 8 Feb 2022 23:00:12 +0000 Subject: [PATCH] SmsProvider class naming --- spec/features/two_factor_authenticatable_spec.rb | 14 +++++++------- spec/rails_app/app/models/user.rb | 2 +- spec/rails_app/lib/sms_provider.rb | 2 +- spec/support/sms_provider.rb | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/features/two_factor_authenticatable_spec.rb b/spec/features/two_factor_authenticatable_spec.rb index d433d63..81f582f 100644 --- a/spec/features/two_factor_authenticatable_spec.rb +++ b/spec/features/two_factor_authenticatable_spec.rb @@ -12,7 +12,7 @@ feature "User of two factor authentication" do end it 'does not send an SMS before the user has signed in' do - expect(SMSProvider.messages).to be_empty + expect(SmsProvider.messages).to be_empty end it 'sends code via SMS after sign in' do @@ -21,8 +21,8 @@ feature "User of two factor authentication" do expect(page).to have_content 'Enter the code that was sent to you' - expect(SMSProvider.messages.size).to eq(1) - message = SMSProvider.last_message + expect(SmsProvider.messages.size).to eq(1) + message = SmsProvider.last_message expect(message.to).to eq(user.phone_number) expect(message.body).to eq(user.reload.direct_otp) end @@ -33,7 +33,7 @@ feature "User of two factor authentication" do expect(page).to have_content('You are signed in as Marissa') - fill_in 'code', with: SMSProvider.last_message.body + fill_in 'code', with: SmsProvider.last_message.body click_button 'Submit' within('.flash.notice') do @@ -67,7 +67,7 @@ feature "User of two factor authentication" do expect(page).to_not have_content("Your Personal Dashboard") - fill_in "code", with: SMSProvider.last_message.body + fill_in "code", with: SmsProvider.last_message.body click_button "Submit" expect(page).to have_content("Your Personal Dashboard") @@ -154,9 +154,9 @@ feature "User of two factor authentication" do end def sms_sign_in - SMSProvider.messages.clear() + SmsProvider.messages.clear() visit user_two_factor_authentication_path - fill_in 'code', with: SMSProvider.last_message.body + fill_in 'code', with: SmsProvider.last_message.body click_button 'Submit' end diff --git a/spec/rails_app/app/models/user.rb b/spec/rails_app/app/models/user.rb index 2093f61..edb1e4f 100644 --- a/spec/rails_app/app/models/user.rb +++ b/spec/rails_app/app/models/user.rb @@ -5,7 +5,7 @@ class User < ActiveRecord::Base has_one_time_password def send_two_factor_authentication_code(code) - SMSProvider.send_message(to: phone_number, body: code) + SmsProvider.send_message(to: phone_number, body: code) end def phone_number diff --git a/spec/rails_app/lib/sms_provider.rb b/spec/rails_app/lib/sms_provider.rb index 363ac10..b70f6e5 100644 --- a/spec/rails_app/lib/sms_provider.rb +++ b/spec/rails_app/lib/sms_provider.rb @@ -1,6 +1,6 @@ require 'ostruct' -class SMSProvider +class SmsProvider Message = Class.new(OpenStruct) class_attribute :messages diff --git a/spec/support/sms_provider.rb b/spec/support/sms_provider.rb index 95556e1..eb37280 100644 --- a/spec/support/sms_provider.rb +++ b/spec/support/sms_provider.rb @@ -1,5 +1,5 @@ RSpec.configure do |c| c.before(:each) do - SMSProvider.messages.clear + SmsProvider.messages.clear end end