* CLDC-4325: Set date to 2026
* CLDC-4325: Fix sale information % tests
I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests
* CLDC-4325: Fix check answers spec
* CLDC-4325: Fix old rake task tests
* CLDC-4325: Fix sales soft validations
* CLDC-4325: Fix collection resources controller spec
* CLDC-4325: Only add noms and org to CSV row if prp
in most cases this was done by default but some tests construct an invalid log
* CLDC-4325: Fix lettings household validations spec
* CLDC-4221: Add 2026 collection deadlines
* CLDC-4325: Fix remaining model specs
* CLDC-4325: Fix form controller spec
* CLDC-4325: Fix hhmemb spec
* CLDC-4325: Fix duplicate logs controller spec
also introduce a new helper for a dynamic way of setting year
* CLDC-4325: Fix sales BU validator spec
* CLDC-4325: Fix check answers summary component
* CLDC-4325: Remove 2024 rake
* CLDC-4325: Use or later in all touched tests
* CLDC-4325: Fix guidance helper spec
* CLDC-4325: Run all tests now and in 2026
* CLDC-4325: Turn off 2026 override
* CLDC-4325: Add a corresponding return to timecop missing one
* CLDC-4325: Fix sales log spec in 2025
need to use let rather than let! so the timecop can run first
* CLDC-4325: Fix lettings log derived spec in 2025
timecop required for the start dates to work
* CLDC-4325: Turn the 2026 override on again
* fixup! CLDC-4325: Fix check answers summary component
* CLDC-4325: Delete recalculate_reasonpref_dontknow rake
only needed for 2024 logs
* fixup! CLDC-4325: Fix lettings household validations spec
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4325: Fix sales log spec in 2025
* fixup! CLDC-4325: Fix sales log spec in 2025
* CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests in current day
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Properly run tests on current day
* fixup! CLDC-4325: Fix sales soft validations
* fixup! CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 1st april
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Revert time travel
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3
I don't think this should have ever been turned on. if we don't know the mortgage we can't assume info in this check
* CLDC-4215: Add a verifying test
* CLDC-4215: Show Don't Know on all paths of mortgageused
* CLDC-4215: Update tests
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
cover all cases
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
* CLDC-4212: Add 0.1% tolerance to % calculations
this is to specifically allow 0.1% more or less than the calculation expects, for those that contain %s in them
this removes difficulties on adding 66.6% equity (or should it be 66.7%?)
* CLDC-4212: Remove discount soft validation
was replaced by a hard validation in CLDC-1899 so no longer serves a purpose
* CLDC-4212: Add tests
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
calculate a tolerance instead
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
update comment
* CLDC-4237: Upgrade ruby to 3.4.4
* CLDC-4237: Add additional build dependencies to Dockerfile
* CLDC-4237: Update rubocop
* CLDC-4237: Fix new rubocop rules
most auto applies
RSpec/IndexedLet had 200 hits needing manual correction so left these for now
* CLDC-4237: Resolve vulnerable dependencies
* CLDC-4237: Fix erb files
* CLDC-4237: Downgrade connection_pool
* CLDC-4090: Add validation that the LA is still active for the date of the log
* CLDC-4090: Add verifying tests
* CLDC-4090: Ensure startdate is not nil for this validation
* CLDC-4090: Document linked validations
* CLDC-4090: Remove errors on uprn_confirmation question
this question is no longer asked, so there are no errors needed for it
left the existing translations
* CLDC-4090: Update tests
* Adjust staircase difference validation to exclude initial purchase
* Update tests
* Keep validation as is, add error to firststair also
* Add method to generate random dates within collection year for logs
* Revert "Update tests"
This reverts commit e708187160.
* Update financial validations tests to reflect new error messages for firststair
* Update sales log test only pick a date up to 14 days away
* Lint
* Adjust merge date for future dates
* Update La test
* Fix date range logic in generate_different_date_within_collection_year method
* Refactor generate_different_date_within_collection_year to use keyword arguments for start and end date overrides in tests
* Refactor sales_log_spec to use descriptive variable names for date overrides
* Refactor merge_requests_helper_spec to use generated merge dates for consistency in tests
* Refactor generate_different_date_within_collection_year
* Refactor sales_log_spec to use generated sale date for duplicate log creation
* Refactor sales_log_spec to use fixed date values for end date and date after end date, mimics change of year without changing year
* Refactor merge_requests_helper_spec to use a fixed merge date for consistency in tests
* Refactor generate_different_date_within_collection_year to handle edge cases and return nil if no available dates
* validate staircasing dates
* validate staircasing percentage totals
* don't show both similar validations at once
* only validate against saledate when saledate present
* format numbers in error message
* add tests for staircasing validations
* linting
* don't block log creation on staircasing date errors
* combine similar validation methods
* update tests
* fix syntax
---------
Co-authored-by: Carolyn <carolyn.barker@softwire.com>
* Skip bu error on the setup question type
* Lint
* Skip bu error on setup question type for equity calculations
* Skip bu error on setup question type for mrent validations
* Skip bu error on setup question type for stairbought validations
* db migration, new sales log fields
* Add new staircasing transaction section
* Update tests
* Lint
* Add tests
* Use log methods
* Lint
* Update test
* Remove compact
* Change section display condition
* CLDC-3760: Sales - firststair and numstair staircasing questions validations (#2793)
* Add validation to new questions firststair and numstair
* Remove page headers on single question page
* Remove page
* More useful page header
* Show don't know option from 2025 onwards
* Add page header to monthly rent only for the version with two questions on the page
* Remove page header staircase initial date only page
* Update displayed answer options
* Fix lint
* Updates after merge
* Update test
* Update tests
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
* Pluralise buyer in household characteristics/setup
* Pluralise buyer in sales information sections
* Pluralise buyer in savings
* Pluralise other buyers, update privacy notice test
* Pluralise buyer in validations and translations
* Route to pages when joint purchase is not answered
* Fix apostrophes
* Update translations
* More updates
* CLDC-3264: Setup to allow using future form on staging for testing
* Update bulk upload year_spec tests
* Fix indentation
* Disable future form use on review apps for testing
* Move lettings startdate 14 day validation to enforce order
* Update tests
* Restore future form use on review apps
Samuel Young
Nat Dean-Lewis
Manny Dinssa
carolynbarker
kosiakkatrina
Rachael Booth
Arthur Campbell
Robert Sullivan