submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Nat Dean-Lewis	f747034261	CLDC-4175: add new service charge question sales (#3200 ) * add the question * CLDC-4174: update question number for 2026 * CLDc-4174: update question number for 2026 * CLDc-4174: update subsection * CLDc-4174: update question specs * CLDC-4174: add subsection spec * CLDc-4174: lint * CLDc-4174: add new page test * CLDC-4241: lint * CLDC-4241: lint * CLDC-4175: db updates * CLDC-4175: add new question to ui flow * CLDC-4175: csv label for new question * CLDC-4175: row parser updates * CLDC-4175: export updates * CLDC-4174: copy updates * CLDC-4174: add validation that new value is different * CLDC-4174: parser updates * CLDC-4174: migration linting * CLDC-4174: add tests * CLDC-4174: fixture updates * CLDC-4174: linting * CLDC-4175: export and test updates * CLDC-4175: row parser field renumbering * CLDC-4175: test fixes * CLDC-4175: test and schema updates post merge * CLDC-4175: lint * CLDC-4175: lint * CLDC-4175: lint * CLDC-4175: add reverse validation * CLDC-4175: cleanup sales_log_to_csv.rb * CLDC-4226: test fixture updates * CLDC-4175: update export spec * CLDC-4175: update validation message * CLDC-4175: remove redundant range validation * CLDC-4175: test with real values in row parser * CLDC-4175: export test updates * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4248: respond to comments * CLDC-4175: remove newservicecharges custom call chain * CLDC-4175: include new spec requirement * CLDC-4175: update financial_validations_spec.rb --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	1 week ago
Nat Dean-Lewis	34664bde2d	CLDC-4178: Add gender same as sex question for sales (#3188 ) * CLDC-4173: add new buildheightclass db changes * CLDC-4173: add new buildheightclass page and question * CLDC-4173: add new buildheightclass bu and export updates * CLDC-4173: update tests * CLDC-4173: update var defs * CLDC-4173: add sales csv export tests for 26 including buildheightclass * CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass * CLDC-4173: update sales export spec * CLDC-4173: update sales export spec and make sales log csv service future-proof * CLDC-4178: add gender same as sex question for sales db changes * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales copy * CLDC-4178: add gender same as sex question for sales person known page * CLDC-4178: add gender same as sex question for sales service updates * CLDC-4178: add gender same as sex question for sales test updates * CLDC-4140: update sales log to csv * CLDC-4140: revert typo * CLDC-4140: update factory * CLDC-4140: update factory * CLDC-4140: filename linting * CLDC-4178: update parser tests * CLDC-4178: update fixtures * CLDC-4173: add missing sales log export fixtures and tests * CLDC-4178: add missing sales log export fixtures and tests * CLDC-4178: update log var defs count * CLDC-4178: fix tests * CLDC-4237: Use each over for_each in sidekiq init (#3196) linter incorrectly assumes it is an activerecord relation * CLDC-4173: date refactoring in tests * CLDC-4173: date refactoring in tests * CLDC-4173: schema updates * CLDC-4173: cleanup and test improvements * CLDC-4173: remove deduplicated code * CLDC-4173: update dates in tests * CLDC-4178: more test date updates * CLDC-4173: test date updates * CLDC-4178: test date updates * CLDC-4178: unused copy cleanup * CLDC-4178: use shared person subsection block from CLDC-4176 * CLDC-4178: comment refactoring * CLDC-4178: person_n_present? updates * CLDC-4178: copy main csv fixtures * CLDC-4178: update csv fixtures * CLDC-4178: factory updates * CLDC-4178: export updates * CLDC-4178: refactoring for consistency with lettings * CLDC-4178: add copy key to gender same as sex * CLDC-4178: fix typo in export test * CLDC-4178: fix typo in locale copy --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	2 weeks ago
Samuel Young	8e7e9f1b71	CLDC-4167, CLDC-4168: Add don't know option to mortgage length questions (#3195 ) * CLDC-4168: Add check for mortgage length known * CLDC-4168: Add mortgage length known to question page * CLDC-4168: Make mortgage length conditional on interview requires a little changing to question logic to account for if the conditional question is not visible right now * CLDC-4168: Add R override to BU * CLDC-4168: Enforce mortlen is not R if buyer not interviewed in BU * CLDC-4168: Update tests * CLDC-4168: Add a lint task that autocorrects * CLDC-4168: Add mortgage length known to sales log factory * CLDC-4168: Allow mortgage not know if buyer wasn't interviewed previously had this the wrong way around. this makes sense because if you interviewed the buyer you should know this * CLDC-4168: Rename mortgage_length_known to mortlen_known matches the mortlen field * fixup! CLDC-4168: Add mortgage length known to question page remove old year numbers * fixup! CLDC-4168: Rename mortgage_length_known to mortlen_known * fixup! CLDC-4168: Allow mortgage not know if buyer wasn't interviewed missed test fix * CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Update tests * CLDC-4168: Allow for "r" in mortlen	2 weeks ago
Nat Dean-Lewis	9c018f8467	CLDC-4176: include new case insensitive fields in field renumbering (#3206 ) * CLDC-4176: fix failing tests * CLDC-4176: renumber case insensitive fields test	2 weeks ago
Samuel Young	3942db4000	CLDC-4176: Remove gender identity question sales (#3201 ) * CLDC-4176: Remove sexn from web UI * CLDC-4176: Remove sexn from BU replace fields with sexrabn ones * CLDC-4176: Remove sexn from CSV export * CLDC-4176: Remove sexn from XML export	2 weeks ago
Samuel Young	97e2170699	CLDC-4012: Allow lower case letters for codes in BU (#3181 ) * CLDC-4012: Add case-sensitive function for 2025 * CLDC-4012: Add case-sensitive function for 2026 * CLDC-4012: Add tests * CLDC-4012: Remove integer attributes * fixup! CLDC-4012: Add tests move R overrides for integers to their own test * fixup! CLDC-4012: Add tests don't check field 58 * fixup! CLDC-4012: Add tests Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>	2 weeks ago
Nat Dean-Lewis	037f59122c	CLDC-4173: add new building height question sales (#3186 ) * CLDC-4173: add new buildheightclass db changes * CLDC-4173: add new buildheightclass page and question * CLDC-4173: add new buildheightclass bu and export updates * CLDC-4173: update tests * CLDC-4173: update var defs * CLDC-4173: add sales csv export tests for 26 including buildheightclass * CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass * CLDC-4173: update sales export spec * CLDC-4173: update sales export spec and make sales log csv service future-proof * CLDC-4173: add missing sales log export fixtures and tests * CLDC-4173: date refactoring in tests * CLDC-4173: date refactoring in tests * CLDC-4173: schema updates * CLDC-4173: test date updates	2 weeks ago
Samuel Young	d79cfcd415	CLDC-4237: Upgrade ruby version (#3190 ) * CLDC-4237: Upgrade ruby to 3.4.4 * CLDC-4237: Add additional build dependencies to Dockerfile * CLDC-4237: Update rubocop * CLDC-4237: Fix new rubocop rules most auto applies RSpec/IndexedLet had 200 hits needing manual correction so left these for now * CLDC-4237: Resolve vulnerable dependencies * CLDC-4237: Fix erb files * CLDC-4237: Downgrade connection_pool	3 weeks ago
Katherine Langford	d2fff16808	CLDC-4177: New Sex At Birth question for sales logs (#3144 ) * CLDC-4177: Create new sex-at-birth question * CLDC-4177: Update database * CLDC-4177: Adds SAB form for the primary buyer. * CLDC-4177: Adds sex-at-birth question for other household members * CLCD-4177: Unit tests * CLDC-4177: Misc inclusions where sex is also used * CLDC-4177: Lint fixes * CLDC-4177: Do not include sexRAB in pre-2026 exports * CLDC-4177: Fixes bug with copy key in new page * CLDC-4177: Changes logic used to decide which fields to export * CLDC-4177: Linting fixes * CLDC-4177: Converts new field to lowercase * CLDC-4177: Satisfy bulk upload tests (not tested manually) * CLDC-4177: Rename new fields to lowercase * CLDC-4177: Rename field in bulk upload. * Fix db casing * CLDC-4177: remove frozen string literals * Delete redundant migration * Remove extraneous lines from schema.rb * Add new sexrab fields to the :completed trait in the Sales Log factory * CLDC-4177: remove redundant inferred CYA vals * CLDC-4177: update bu files * CLDC-4177: update sales log export service * CLDC-4177: update schema * CLDC-4177: linting * CLDC-4177: update sales log export constants * CLDC-4177: update factories * CLDC-4177: lint * CLDC-4177: csv parser updates * CLDC-4177: bu field updates * CLDC-4177: update var def spec * CLDC-4177: make to_2026_row explicit * CLDC-4177: use shared field count * CLDC-4177: refactor to remove max cols going forwards * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: remove X from factory options * CLDC-4177: update log var defs * CLDC-4177: use correct shared field count * CLDC-4177: remove trailing commas * CLDC-4177: update bulk upload csv example * CLDC-4177: update bulk upload csv example * CLDC-4177: remove sexrab from expected sales export for now --------- Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com> Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>	1 month ago
Samuel Young	a513984440	CLDC-4162: Set up Bulk Uploads for 2026 (#3134 ) * CLDC-4162: Add parsers for 2026 * CLDC-4162: Integrate 2026 parsers into codebase * CLDC-4162: Add tests * CLDC-4162: Update tests for existing years remove year dependencies where possible * CLDC-4162: Add example 2026 bulk upload files * CLDC-4162: Update BU test file generate buttons * fixup! CLDC-4162: Update BU test file generate buttons we only need the 14 days validation when the future forms feature toggle is off, otherwise any date can be input * fixup! CLDC-4162: Integrate 2026 parsers into codebase improve TODOs * fixup! CLDC-4162: Add parsers for 2026 add todos for unknown info * fixup! CLDC-4162: Update tests for existing years properly mark year specific tests * fixup! CLDC-4162: Update tests for existing years use 25 over 2025 * fixup! CLDC-4162 Update BU test file generate buttons --------- Co-authored-by: carolynbarker <8038496+carolynbarker@users.noreply.github.com>	2 months ago
Samuel Young	138d538179	CLDC-4013: Update sale type bulk uploading wording for 25/26 (#3110 ) question changed error text changed	5 months ago
Manny Dinssa	95157d9c82	CLDC 4001: Change apostrophes that look like quotes (#3044 ) * Update text copy to use curly apostrophes for consistency * Update BU text copy to use curly apostrophes for consistency * Update BU text copy to use curly apostrophes for consistency * Update text copy to use 'Other' for consistency in instead of 'other' * Update text copy for 'Reasonable preference reason' fields to improve clarity * Update tests	12 months ago
Manny Dinssa	4ec01d5fee	CLDC-3919: Sales BU Decimal numbers rounding errors (#2987 ) * Update discount attribute to be saved as a float * Equity fields as decimals * Stairbought and stairowned fields as decimals * mrentprestaircasing as decimal * value fields as decimal * deposit fields as decimal * cashdis as decimal * mscharge fields as decimal * mortgage fields as decimal * Update 2024 value fields * Update 2024 mortgage fields * Update 2024 deposit fields * Update 2024 cashdis field * Update 2024 stairbought and stairowned fields * Update 2024 equity field * Update 2024 discount field * Update 2024 mscharge fields (2/3)	1 year ago
carolynbarker	61d412577c	CLDC-3904 remove default from relat mapping (#2993 ) * remove default from relat mapping * update valid test data * fix field number * add validation messge for other values --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com>	1 year ago
Manny Dinssa	1bc39f0ed1	CLDC-3917: Sales BU numstair question range error message (#2984 ) * Calculate legend size of date question * Add numeric error message to numstair question	1 year ago
Manny Dinssa	548c2007e4	CLDC-3905 BU Sales 25/26 Buyer relationship validation error (student/child check) (#2972 ) * Remove student_not_child_value_check in 2025 * Correct field numbering on person 4 and 5 * Update test	1 year ago
kosiakkatrina	27d7c4689f	CLDC-3845 Save manually entered address in BU (#2948 ) * Update BU addresses flow * Refactor	1 year ago
Manny Dinssa	5da13b6b29	CLDC-3787: Autocomplete address uprn search (#2967 ) * Prototype * Remove git from dockerfile * UPRN search too * Revert address client and use uprn client * Add address search to lettings too * Updates with lettings logs * Update copy * Move guidance to partial * Fix uprn return * Delete new db file, restore old * Lint * Remove old db file * Lint * Add new db file, remove old * JS lint * Update schema * Add manual entry option * Update derived variables * Comment out old version of find address in 2024 * Remove db column * Add new db columns * Update guidance partial * Add unless to migration * Add migration files to remove and readd * authenticate user * Remove file * Delete migration files * Add search url * Add search url * Fix onConfirm * Add manual entry button instead of change skip link * Revert "Add manual entry button instead of change skip link" This reverts commit `22577c801a`. * Revert "Revert "Add manual entry button instead of change skip link"" This reverts commit `9f0a2111a5`. * Replace uprn question * Update question copy * Allow changing the address search value * Rename address autocomplete to address search * Add buttons to switch between address questions * Fix controller logic * Enable adding question numbers to page headers * Update skip links * Add js disabled message to select * Alternative way to handle js disabled users * Revert "Alternative way to handle js disabled users" This reverts commit `10da3d61e2`. * Fix typo * Fix address options for address search question * Reuse AddressDataPresenter where appropriate * Lint * Remove uprn selection question tests * Reuse UprnDataPresenter where appropriate * CSV export, exclude address_search * Add address search to sales and lettings factory bots * Exclude old address questions from routing, keep as exported values * lint * Update uprn value * Add address search input boolean and switch between questions * Reword copy, remove "Find" and "Search by" * Align address questions, add question number and question text * Remove old wip depends on * Update some tests * Update migration, move default value from db to model * Update test * Remove binding pry * Lint * Update test * Lint * Update test * Update routes with underscores * Remove debugging * Limit visible logs to user * Add manual address entry selected variable * Change address search min length to 3chars * Remove binding.pry * Update factory bots, manual_address_entry_selected to true for preexisting tests * Update model tests * Update sales model tests excl E-code tests * Update address search request test * Reuse uprn id instead of address_search * Set manual address entry selected as false when creating test logs * Update model test * Update request tests and remove old questions * Add back test * Update services * Update more tests Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com> * Update request tests * update model tests * Also update sales log * Update service csv uprn_selection values to 1 * Add tests for pages and questions * Update test * Update uprn_known * Lint * Add feature test * Update test * Update tests * Remove test * pre-consolidate migration files * Indentation * Controller method improvements * Update question numbers for 2025/26 * Update question numbers tests * consolidate and delete old migration files * undo changes to schema.rb * Update 2025 property information translation files * Update answer options to show singular previously selected result if present * Move buttons to bottom guidance partials * Small improvements, make address search and existing search more similar * Validate entered addresses as within England * Update test * Revert "Validate entered addresses as within England" This reverts commit `2dbfbcc8a5`. * Add missing button to sales address page * Change error code * Clear invalid options * Edit no results message method * Keep no result logic just change text * Display uprn value with address value * Still show no results message when characters entered is less than 3 rather than nothing * Fix uprn result when query is ambiguous * Reduce min match for address search * Hide no result found message just before results are populated * Prevent changing logs to 2025 with invalid addresses * Correct attribute name * Handle nil * Remove custom error message * Remove unused variables from factory * Update tests, remove address and postcode from old find address * Fix bug clearing uprn from see all answers * Revert "Fix bug clearing uprn from see all answers" This reverts commit `a66c47a1ab`. * Undo changes to validation method * Fix unchanged uprn_selection when clearing or changing uprn * Undo a change * Update bulk upload 2025 * Fix typo * Remove redundant line --------- Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>	1 year ago
Manny Dinssa	f320687294	Revert "CLDC-3787 Autocomplete address search (#2924 )" (#2965 ) This reverts commit `29a469b668`. Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	1 year ago
Manny Dinssa	29a469b668	CLDC-3787 Autocomplete address search (#2924 ) * Prototype * Remove git from dockerfile * UPRN search too * Revert address client and use uprn client * Add address search to lettings too * Updates with lettings logs * Update copy * Move guidance to partial * Fix uprn return * Delete new db file, restore old * Lint * Remove old db file * Lint * Add new db file, remove old * JS lint * Update schema * Add manual entry option * Update derived variables * Comment out old version of find address in 2024 * Remove db column * Add new db columns * Update guidance partial * Add unless to migration * Add migration files to remove and readd * authenticate user * Remove file * Delete migration files * Add search url * Add search url * Fix onConfirm * Add manual entry button instead of change skip link * Revert "Add manual entry button instead of change skip link" This reverts commit `22577c801a`. * Revert "Revert "Add manual entry button instead of change skip link"" This reverts commit `9f0a2111a5`. * Replace uprn question * Update question copy * Allow changing the address search value * Rename address autocomplete to address search * Add buttons to switch between address questions * Fix controller logic * Enable adding question numbers to page headers * Update skip links * Add js disabled message to select * Alternative way to handle js disabled users * Revert "Alternative way to handle js disabled users" This reverts commit `10da3d61e2`. * Fix typo * Fix address options for address search question * Reuse AddressDataPresenter where appropriate * Lint * Remove uprn selection question tests * Reuse UprnDataPresenter where appropriate * CSV export, exclude address_search * Add address search to sales and lettings factory bots * Exclude old address questions from routing, keep as exported values * lint * Update uprn value * Add address search input boolean and switch between questions * Reword copy, remove "Find" and "Search by" * Align address questions, add question number and question text * Remove old wip depends on * Update some tests * Update migration, move default value from db to model * Update test * Remove binding pry * Lint * Update test * Lint * Update test * Update routes with underscores * Remove debugging * Limit visible logs to user * Add manual address entry selected variable * Change address search min length to 3chars * Remove binding.pry * Update factory bots, manual_address_entry_selected to true for preexisting tests * Update model tests * Update sales model tests excl E-code tests * Update address search request test * Reuse uprn id instead of address_search * Set manual address entry selected as false when creating test logs * Update model test * Update request tests and remove old questions * Add back test * Update services * Update more tests Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com> * Update request tests * update model tests * Also update sales log * Update service csv uprn_selection values to 1 * Add tests for pages and questions * Update test * Update uprn_known * Lint * Add feature test * Update test * Update tests * Remove test * pre-consolidate migration files * Indentation * Controller method improvements * Update question numbers for 2025/26 * Update question numbers tests * consolidate and delete old migration files * undo changes to schema.rb * Update 2025 property information translation files * Update answer options to show singular previously selected result if present * Move buttons to bottom guidance partials * Small improvements, make address search and existing search more similar * Validate entered addresses as within England * Update test * Revert "Validate entered addresses as within England" This reverts commit `2dbfbcc8a5`. * Add missing button to sales address page * Change error code * Clear invalid options * Edit no results message method * Keep no result logic just change text * Display uprn value with address value * Still show no results message when characters entered is less than 3 rather than nothing * Fix uprn result when query is ambiguous * Reduce min match for address search * Hide no result found message just before results are populated * Prevent changing logs to 2025 with invalid addresses * Correct attribute name * Handle nil * Remove custom error message * Remove unused variables from factory * Update tests, remove address and postcode from old find address * Fix bug clearing uprn from see all answers * Revert "Fix bug clearing uprn from see all answers" This reverts commit `a66c47a1ab`. * Undo changes to validation method * Fix unchanged uprn_selection when clearing or changing uprn * Undo a change * Update bulk upload 2025 * Fix typo * Remove redundant line --------- Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>	1 year ago
carolynbarker	e5d10e219f	CLDC-3802 sales bulk upload update 2025 (#2945 ) * add 2025 sales bulk upload parser * lint and fix typos * fix typos, field numbers, staircasing tests * order field_11 values * test log creator selects correct year's parser * fix log to csv helper field order * update factory so test file fully succeeds * add 2025 BU test file method * apply new csv syntax * lint * lint * CLDC-3893 update property information field order * commonise prepare your file page * also update prep file page for lettings * CLDC-3893 update test * lint * don't error on blank discount if not RTB --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com>	1 year ago

10 Commits (f74703426136f0cc9771741ff3b7ce9a0c4667a4)