submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
oscar-richardson-softwire	e1c415bd48	Fix lint	3 days ago
oscar-richardson-softwire	76821a1410	Fix lettings log derived fields tests	3 days ago
oscar-richardson-softwire	a4cf2e79d6	Add tests for resetting address fields and LA	3 days ago
Samuel Young	fe65438a2a	CLDC-4145: Don't ask partner for children (#3141 ) * CLDC-4145: Derive is partner for under 16s in contrast, clear is partner if the age goes >=16 so the user must answer the question again * CLDC-4145: Remove under 16 soft validation for 2026 it will no longer be shown as we infer the answer * fixup! CLDC-4145: Derive is partner for under 16s * fixup! CLDC-4145: Remove under 16 soft validation for 2026 the check is added twice before two diff questions * CLDC-4145: Update tests * fixup! CLDC-4145: Derive is partner for under 16s lint * fixup! CLDC-4145: Update tests lint * fixup! CLDC-4145: Derive is partner for under 16s check if the was was null rather than current. avoids potential bugs on first assign * fixup! CLDC-4145: Update tests some more tests added / updated * fixup! CLDC-4145: Update tests turns out editing the future form use is not possible for tests, too many depend on it failing use timecop instead * fixup! CLDC-4145: Update tests fix lettings log export * fixup! CLDC-4145: Update tests add 2024 derived variable tests * fixup! CLDC-4145: Update tests lint * CLDC-4145: Add a depends_on to ensure partner is hidden * fixup! CLDC-4145: Add a depends_on to ensure partner is hidden remove unnecessary depends_on make test ranges clearer	4 days ago
Samuel Young	ac17087728	CLDC-3870: Ask number of bedrooms when changing answer to non bedsit (#3123 ) * CLDC-3870: Nil the beds question when the user changes off of bedsit this forces the user to answer it again as we previously assumed the answer to be '1' when they answered bedsit * CLDC-3870: Add tests	2 months ago
dependabot[bot]	a08d6e8a04	Bump activerecord from 7.2.2.1 to 7.2.2.2 (#3099 ) * Bump activerecord from 7.2.2.1 to 7.2.2.2 Bumps [activerecord](https://github.com/rails/rails) from 7.2.2.1 to 7.2.2.2. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.2.1/activerecord/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.2.2.1...v7.2.2.2) --- updated-dependencies: - dependency-name: activerecord dependency-version: 7.2.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * CLDC-NONE: fix test impacted by BigInteger update calculator verifies that this is the correct answer and previous was wrong * CLDC-NONE: fix financial test impacted by BigInteger update 19.99 / 2 rounds to 10 so this test looks to be wrong --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Samuel Young <samuel.young@softwire.com>	5 months ago
carolynbarker	7058c9838a	CLDC-3938 set ppostcode on postcode change to fix bu bug (#2994 ) * set renewal ppostcode on postcode change * update test * don't validate ppostcode format if nil * reset ppcodenk if ppcode errors --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com>	10 months ago
carolynbarker	944b4f4f1f	CLDC 3899 fix deactivation period edge case bugs (#2995 ) * rename variable for clarity * remove unused variable * make reactivating_soon message refer to the soonest, not most recently created * status check all deactivation periods instead of just one * handle no open period to reactivate * test deactivation period related behaviour * fix reactivation message variable syntax * use before do instead of let for unreferenced variables * fix reactivation message syntax for location * fix test indentation * remove unused variable - part 2 * lint * handle edge case of overlapping periods * end unclosed Timecop freeze causing flaky tests * remove unused around blocks superseded by befores * tidying up * reinstate setup needed to test default date * fix typo * explain deactivation period validation logic * fix setup to test default date --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	10 months ago
Manny Dinssa	fe89619b1f	CLDC-3876: Household characteristic ecstat of child under 16 bug fix when age changed (#2959 ) * Clear derived working situation of child under 16 when age is changed to 16 or above * Add tests	11 months ago
kosiakkatrina	5b3c57481a	CLDC-3844 Add rent type response (#2900 ) * Update answer options for 2025 * Correctly derive variables from new rent type option * Update missed test * Remove git version from dockerfile	1 year ago
Rachael Booth	72a52a58c9	CLDC-3387: Allow support users to create notifications (#2613 ) * CLDC-3387: Allow support users to create notifications * Refactor rendering * Adjust notifications helper * Add rubocop ignore * Fix path checks around notification viewing * Notification path regex should work on review apps * Tidy * Remove unused function * Reference external url in link to markdown syntax guide * CLDC-3614: Allow markdown page content when creating notifications (#2622) * CLDC-3614: Allow markdown page content when creating notifications * Try using beginning of day for time in failing test * Remove ignored breaks * Add paper trail to notifications * CLDC-3607: Allow support users to delete notifications (by setting their end date) (#2630) * CLDC-3607: Allow support users to delete notifications (by setting their end date) * Refactor render_for_page helper * Move db queries to homepage presenter * Fix lint * Use a before_action to find notification in controller * Make delete notification links red * Tweak link to markdown guide * Open markdown guide in new tab	1 year ago
kosiakkatrina	5947a2027a	CLDC-3496 Move period creation to log (#2490 ) * Move period creation to log * Allow adding rent periods to organisations * Update more tests	2 years ago
Rachael Booth	10732f92f2	CLDC-3487: Ensure locations and previous_la_known are cleared when necessary (#2452 ) * CLDC-3487: Clear previous_la_known when necessary for renewal logs * CLDC-3487: Clear location when clearing scheme due to org change * CLDC-3487: Use nil instead of 0 * Specify orgs on sh logs when needed for tests * Fix flaky tests	2 years ago
Rachael Booth	92dc829e8e	CLDC-3463: Fix bug with vacdays calculation (#2444 ) * CLDC-3463: Fix bug with vacdays calculation * CLDC-3463: Fix lettings csv export tests * Lint * Use build_stubbed where necessary for lettings logs in tests * Update all logs in rake task but without validation * Try validations in rake tasks and log when needing to skip them	2 years ago
Arthur Campbell	a24bafe5df	Cldc 3114 enable support control of rent periods per organisation (#2442 ) * write helper method to support having the correct rent period checkboxes checked * update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this * small changes to models * enable editing rent period in the UI display change button on org details page display rent periods question on edit page * enable updating org rent periods update logic in #update related tests * alter redirect after support user creates an organisation * adjust various UI elements: ordering of rows, copy changes, label size and associated tests * rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update * amend failing tests and resolve linting complaints * changes following review * disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method * update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions * rake task to create rent period associations for orgs that have none * revert mistaken copy changes in designs * create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods * stub api call for factory value, update csv tests and fixtures accordingly * extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests * remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code * escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db * further refactoring of various tests to reduce database interactions and improve speed * remove outdated distinction between unitletas mappings from before 23/24 * remove tests that seem to be testing active record and/or ruby Date class	2 years ago
Arthur Campbell	1ebf71129e	Revert "Cldc 3114 enable support control of rent periods per organisation (#2…" (#2439 ) This reverts commit `eda367afb0`.	2 years ago
Arthur Campbell	eda367afb0	Cldc 3114 enable support control of rent periods per organisation (#2389 ) * write helper method to support having the correct rent period checkboxes checked * update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this * small changes to models * enable editing rent period in the UI display change button on org details page display rent periods question on edit page * enable updating org rent periods update logic in #update related tests * alter redirect after support user creates an organisation * adjust various UI elements: ordering of rows, copy changes, label size and associated tests * rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update * amend failing tests and resolve linting complaints * changes following review * disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method * update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions * rake task to create rent period associations for orgs that have none * revert mistaken copy changes in designs * create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods * stub api call for factory value, update csv tests and fixtures accordingly * extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests * remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code * escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db * further refactoring of various tests to reduce database interactions and improve speed * remove outdated distinction between unitletas mappings from before 23/24 * remove tests that seem to be testing active record and/or ruby Date class	2 years ago

17 Commits (e1c415bd4806c9743530244a6faa51bc5e4fc82e)