submit-social-housing-lettings-and-sales-data

982 Commits

0 Branches

320 Tags

90 MiB

Tree: d5ebb72884

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	6c5391ad1c	Cldc 1065 soft validations (#434 ) * change get_question form method to prioritise the routed to questions * Add soft validation and interruption screen for basic rent * get previous page that was routed to and display the same error for both soft validations * Separate max and min error screens * add a test for getting the previous page * Update content and add more tests for previous page	5 years ago
Dushan	484bb499e6	CLDC-788 interruption screen net income soft validation (#372 ) * Set up failing test for new soft validation design * remove unneeded js controller * remove unneeded controller and spec * rename net income validation override column * spec form changes (to allow tests to run) * validation spec changes * replace all instances of override_net_income_validatiom * passing first test * Add to form and import styling * remove unneeded code from interruption screen view * Update test & code - failing last new expectation * Display 2 previous question answers in the informative text * extract displaying of the informative text into a helper * Add tests for helper * Remove some of the previous soft validations set up * fix some failing specs * Fix more tests * lint * Reset earnings question prefix and suffix to initial values instead of nil * make it route backwards on a no * test and linter fixes * refactor next_page * stryling * more changes * fix specs * update real form * design tweaks * delete commented out tests * content changes * content changes * changes to informative/hint text * More robust styles for interuption panel, use smart quotes * Rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com> Co-authored-by: baarkerlounger <db@slothlife.xyz>	5 years ago

Author

SHA1

Message

Date

kosiakkatrina

6c5391ad1c

Cldc 1065 soft validations (#434 )

* change get_question form method to prioritise the routed to questions

* Add soft validation and interruption screen for basic rent

* get previous page that was routed to and display the same error for both soft validations

* Separate max and min error screens

* add a test for getting the previous page

* Update content and add more tests for previous page

5 years ago

Dushan

484bb499e6

CLDC-788 interruption screen net income soft validation (#372 )

* Set up failing test for new soft validation design

* remove unneeded js controller

* remove unneeded controller and spec

* rename net income validation override column

* spec form changes (to allow tests to run)

* validation spec changes

* replace all instances of override_net_income_validatiom

* passing first test

* Add to form and import styling

* remove unneeded code from interruption screen view

* Update test & code - failing last new expectation

* Display 2 previous question answers in the informative text

* extract displaying of the informative text into a helper

* Add tests for helper

* Remove some of the previous soft validations set up

* fix some failing specs

* Fix more tests

* lint

* Reset earnings question prefix and suffix to initial values instead of nil

* make it route backwards on a no

* test and linter fixes

* refactor next_page

* stryling

* more changes

* fix specs

* update real form

* design tweaks

* delete commented out tests

* content changes

* content changes

* changes to informative/hint text

* More robust styles for interuption panel, use smart quotes

* Rubocop

Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>

5 years ago

2 Commits (d5ebb72884bdd0af6884c60f06ea8c07764f7caf)