baarkerlounger/submit-social-housing-lettings-and-sales-data - submit-social-housing-lettings-and-sales-data - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
David May-Miller	4a31906d45	CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>	3 years ago
Arthur Campbell	648e344af6	CLDC-1786 add validations for staircasing transaction (#1235 ) * change percent to % so that suffix is consistent with other similar questions * fix rebase conflicts * add hard validation that percentage owned after a staircasing transaction cannot be less than the percentage bought in that transaction, with associated tests * add compound validation to ensure that logs of type older person shared ownership may not have a stairbought value of greater than 75% \n associated tests included * remove duplicate method and use existing version * fix rebase conflicts * ensure schema correct and test of page number correct * fix form handler test after rebase * fix tests and ensure schema correct after rebase	3 years ago
kosiakkatrina	7bd76c4d32	CLDC-1575 Add shared ownership validations (#1217 ) * Add income error to ownership type and ecstat fields * Add shared_ownership_deposit_value_check field * Add shared_ownership_deposit_invalid? soft validation * Add shared ownership deposit check pages and questions * Add pages to the subsection and update validation message * tests * Update validation to only trigger if la is given * Run the soft validation when mortgage isn't used or cash discount isn't given * test	3 years ago
Arthur Campbell	1cced31e27	hard validation on value of cash discount (#1221 )	3 years ago
kosiakkatrina	514552934d	Sales financial validations (#1079 ) * Include shared validations in sales log model and run validate_numeric_min_max method * Add non london hard max income validation * Add london income validation * Remove child vlidation because buyer cannot be a child * Add income1_value_check column * Add buyer_1_income_value_check question and page * Update income1_under_soft_min? * Add mortgage and value check column * Add mortgage value check page * Update mortgage_over_soft_max? in soft validateions * Remove unused error message	4 years ago