submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Samuel Young	f5f0e663e0	CLDC-4184: Update question numbers for sales (#3221 ) * CLDC-4184: Consolidate logic for questions that appear in multiple subsections * CLDC-4184: Ensure all 2025 questions have a number * CLDC-4184: Add 2026 question numbers * CLDC-4184: Update question numbers to match paper form * CLDC-4184: Use the standard question hash function * CLDC-4184: Lint * CLDC-4184: Update tests * fixup! CLDC-4184: Update question numbers to match paper form * CLDC-4184: Commonise person question logic in sales * fixup! CLDC-4184: Update question numbers to match paper form add missing 2026 question * fixup! CLDC-4184: Use the standard question hash function missed nationality * fixup! CLDC-4184: Update question numbers to match paper form fix q111 * fixup! CLDC-4184: Update question numbers to match paper form some missed questions * CLDC-4184: Lint * CLDC-4184: Fix test	3 weeks ago
Samuel Young	8e7e9f1b71	CLDC-4167, CLDC-4168: Add don't know option to mortgage length questions (#3195 ) * CLDC-4168: Add check for mortgage length known * CLDC-4168: Add mortgage length known to question page * CLDC-4168: Make mortgage length conditional on interview requires a little changing to question logic to account for if the conditional question is not visible right now * CLDC-4168: Add R override to BU * CLDC-4168: Enforce mortlen is not R if buyer not interviewed in BU * CLDC-4168: Update tests * CLDC-4168: Add a lint task that autocorrects * CLDC-4168: Add mortgage length known to sales log factory * CLDC-4168: Allow mortgage not know if buyer wasn't interviewed previously had this the wrong way around. this makes sense because if you interviewed the buyer you should know this * CLDC-4168: Rename mortgage_length_known to mortlen_known matches the mortlen field * fixup! CLDC-4168: Add mortgage length known to question page remove old year numbers * fixup! CLDC-4168: Rename mortgage_length_known to mortlen_known * fixup! CLDC-4168: Allow mortgage not know if buyer wasn't interviewed missed test fix * CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Update tests * CLDC-4168: Allow for "r" in mortlen	1 month ago
kosiakkatrina	ac1d2ce8d9	CLDC-3806 Update question numbers for sales (#2936 ) * Update question numbers * Update tests * Update constant name * Fix proplen number for 2024	1 year ago
Rachael Booth	542565ed85	Use subsection copy key (#2792 ) * CLDC-3766: Ensure copy for Q78 is found correctly * Fix tests * Use subsection copy key in defaults and remove explit keys that are now defaults * Replace other uses of subsection.id interpolation in copy keys * Test copy key when specified on subsection * Update tests * Update privacy notice page tests * More test fixes	1 year ago
kosiakkatrina	51bc0cffeb	CLDC-3665 Extract sale information copy (#2711 ) * Extract shared ownership copy * Extract discounted ownership copy * rename files * CLDC-3665 Extract sale information soft validations (#2712) * Extract shared ownership copy * Extract shared ownership soft validations * Extract discounted ownership validations * Fix mappings * Update some translations * Remove full stops	1 year ago
kosiakkatrina	6717eb6275	CLDC-3181 Update question numbers for 2024 (#2252 ) * Update question numbers for 2024 * Stub form in tests * Stub form start_date for pages * Add a default question number * Fix a typo * Update rebase test * Refactor default question number * Refactor person question numbers * Display managing org for sales correctly in CYA * Rebase fix * More tweaks	2 years ago
Robert Sullivan	24a3f3eee8	CLDC-2049: Use year instead of years when only one is displayed (#2262 ) * CLDC-2049: Use year instead of years when only one is displayed * CLDC-2049: Also use year instead of years for mortgage question	2 years ago
Arthur Campbell	720f7ca0e2	CLDC-1945 numeric questions decimal letter entry (#1558 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase * amend step value on earnings	3 years ago
Arthur Campbell	f57b93045d	Revert "CLDC-1945 numeric questions decimal letter entry (#1442 )" (#1555 ) This reverts commit `c78f2ef5f9`.	3 years ago
Arthur Campbell	c78f2ef5f9	CLDC-1945 numeric questions decimal letter entry (#1442 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase	3 years ago
natdeanlewissoftwire	c862423adf	CLDC-1864 single log numbering (#1381 ) * feat: add initial question number behaviour * feat: add initial CYA behaviour * feat: number sales setup section * refactor: lint * feat: property information numbering * feat: household characteristics section and typo fix * feat: household characteristics numbering * feat: household situation numbering * feat: other household info numbering * feat: income, benefits and outgoings numbering * feat: shared ownership scheme numbering * feat: shared, discount and outright numbering * feat: fix income duplication bug, add numbers to other questions * feat: typo fix * feat: add lettings setup numbering * feat: add property info numbering * feat: add household char numbering * feat: add household needs numbering * feat: add household situ numbering * feat: add income numbering * feat: update tests * refactor: cleanup and disable on 2022 and before logs * feat: add test for q numbers in 23/24 year only * refactor: highlight multiplication in brackets * feat: show rent and charge questions individually on cya * feat: number new previous tenure q * feat: delete old prevten file * feat: update card numbers after merge * feat: add q60 ands 61 sales * refactor: delete empty files --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	3 years ago
Jack	9d80f6d245	Add max range to mortgage length (#1245 )	3 years ago
Jack	c2c1b4dbb0	Add mortgage length hint (#1237 )	3 years ago
kosiakkatrina	c339ffda1f	Cleanup the form (#1166 ) * Remove empty descriptions from pages * remove empty headers from pages * Remove redundant subsection assignment from pages * Remove redundant page assignement from questions * Remove redundant section assignment from subsections * Remove redundant form assignments from sections * Remove empty hint texts from questions * lint	3 years ago
natdeanlewissoftwire	d447ad10ee	Cldc 1750 length of mortgage (#1163 ) * feat: add question and page and update db * test: add tests * feat: update schema * test: update tests * test: update tests * feat: address test failure	3 years ago

15 Commits (8bddf92a0bc42d152ad97c1f94de7240fdc113dd)