submit-social-housing-lettings-and-sales-data

2983 Commits

270 Branches

320 Tags

90 MiB

Tree: 8618e38a42

Commit Graph

Author	SHA1	Message	Date
Phil Lee	cae731ed6f	CLDC-1888 Bulk upload handles duplicates (#1334 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-1888 - This is a continuation of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1277 - When bulk uploading we want to check users are not uploading data that already exists to prevent them submitting duplicate # Changes - This feature is behind a feature toggle. it has been disabled for staging for testing purposes but available in all other environments - If a log already exists based off certain fields add errors to the associated fields - We discount any hidden logs and only check "active" logs - Added memoization to `#valid?` as an optimisation	4 years ago
Phil Lee	81bdd1475c	CLDC-1780 Bulk upload summary (#1242 ) * add placeholder for bulk upload error summary * persist column for bulk upload errors * replace bulk upload summary table placeholder	4 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	4 years ago

Author

SHA1

Message

Date

Phil Lee

cae731ed6f

CLDC-1888 Bulk upload handles duplicates (#1334 )

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-1888
- This is a continuation of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1277
- When bulk uploading we want to check users are not uploading data that already exists to prevent them submitting duplicate 

# Changes

- This feature is behind a feature toggle. it has been disabled for staging for testing purposes but available in all other environments
- If a log already exists based off certain fields add errors to the associated fields
- We discount any hidden logs and only check "active" logs
- Added memoization to `#valid?` as an optimisation

4 years ago

Phil Lee

81bdd1475c

CLDC-1780 Bulk upload summary (#1242 )

* add placeholder for bulk upload error summary

* persist column for bulk upload errors

* replace bulk upload summary table placeholder

4 years ago

Phil Lee

197e2ae4cb

[1778] Bulk upload errors (#1091 )

* lockdown bulk upload routes

* able to view lettings bulk upload errors

* add error count to bulk upload results

* coverage for bulk upload filename on results

* group bulk upload errors by row on results

* able to view bulk upload sales results

* scope lettings and sales bulk upload results

* fix linting

* call service correctly in test

* add bulk upload sales questions mapping

* appease linter

* bulk upload error shows correct question

- depending on log type it will show relevant question for the field
  concerned

* use local disk for bulk upload for dev env

- this saves the need to connect to S3 to play with bulk upload in dev
  environment

* improve namespacing of classes

* add job to process bulk uploads

* use local disk storage for dev file upload

* fix test

* use inline active job queue_adapter for dev

* use test active job queue adapter for test env

* remove rubocop violation

* delete bulk upload from disk after processing

* populate errors with cell, row + metadata

* update error message with something meaningful

* shim in sales validator

* able to parse sales bulk uploads

* change migration to add purchase_code to errors

* bulk upload error component renders purchaser code

- when a sales log

* populate purchaser_code for bulk upload errors

- when log type is sales

* remove superfluous private method

4 years ago

3 Commits (8618e38a42fbd85aa33e20684ee8cf4b22537d82)