738ebe355f
Update BU text copy to use curly apostrophes for consistency
10 months ago
b1052018cc
Update BU text copy to use curly apostrophes for consistency
10 months ago
1e968e50a6
CLDC-3694 Extract lettings BU validations
1 year ago
64caf018e0
CLDC-2413 Allow 4 digit year format for bulk uploads ( #2715 )
...
* Allow 4 digit years for start date/sale date
* Update other dates
1 year ago
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
1 year ago
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
1 year ago
331ee8f0e8
CLDC-3575: Remove reference to dluhc on GitHub ( #2581 )
...
* Update github README.md picture
* Change name
* Remove old image & change private to public beta text
1 year ago
8dcd80e4f8
Strip scheme ID ( #2487 )
2 years ago
4a5a912816
CLDC-3483: Prevent/fix missing letting allocation values ( #2453 )
...
* CLDC-3483: Enforce that all lettings allocation method fields are present for bulk uploads
* CLDC-3483: Add task to fix existing nil letting allocation values
* Better capitalisation
* Keep previous punctuation
* Use find_each for task
2 years ago
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
2 years ago
a0842064fb
Update privacy notice BU validation ( #2377 )
2 years ago
b9d93fe732
Revert all charges given validation ( #2308 )
2 years ago
7c30c33868
CLDC-3283 Validate allocation values ( #2294 )
...
* Validate allocation values for 2024
* Validate allocation values for 2023
2 years ago
8c25e70127
CLDC-3215 Add charges bu errors ( #2250 )
...
* Validate all relevant charges given for BU 2023
* Validate all relevant charges given for BU 2024
2 years ago
b4cd777897
CLDC-2972 Warn users about answers that will be cleared in bulk upload ( #2142 )
...
* Empty commit
* feat: base lettings behaviour
* feat: formatting improvements
* Empty commit
* Empty commit
* Empty commit
* refactor: lint
* feat: more page styling
* feat: update tests
* refactor: lint
* feat: add requests spec
* refactor: simplify
* feat: add tests
* feat: copy change to reflect that the count in the header is not necessarily as large as the errors shown (it excludes duplicate errors on fields, and not_answered errors)
* feat: copy changes to sales as well
* feat: remove LegacyBulkUpload MVC
* feat: fix typo
* feat: update tests
* feat: mark additional not_answered sales q
* feat: update routing and only display warnign text when errors will be cleared
* feat: update copy and error rows
* refactor: lint
* feat: don't show soft validations in deletion report
* feat: update routing so deletion report is not shown once logs uploaded
* feat: update tests
* feat: make unique count track repeated errors across rows
* refactor: lint
2 years ago
6c044fd036
CLDC-3034 Fix bulk upload error on empty field bug ( #2135 )
...
* feat: don't add empty assignments in field_mapping_for_errors
* feat: use empty arrays
* feat: revert previous commit
* feat: add previously failing test
2 years ago
763094eb0b
CLDC-3034 Ignore household charge in general needs bulk uploads ( #2123 )
...
* feat: ignore household_charge for general needs logs
* feat: add tests
* feat: add tests
* refactor: lint
2 years ago
991d3a5ffa
CLDC-3067 Surface organisation and date errors in summary ( #2104 )
...
* Surface organisation and date errors in summary
* Refactor
* Refactor sales row parser
* Check that question is present
2 years ago
53ae65774b
Validate rent_type subquestions ( #2109 )
2 years ago
fa3b5d16a3
Remove duplicate validations, add correct category ( #2106 )
2 years ago
ba005a626b
Update type missmatch error messages ( #2105 )
2 years ago
b813b73cf3
CLDC-2977 Only allow blank age when person is not given ( #2103 )
...
* Set age known correctly for lettings
* Set age known correctly for sales
2 years ago
0ee9ba9932
Correctly map location and scheme errors ( #2101 )
2 years ago
6bdf9f3945
CLDC-2956 Update allocation system error messages ( #2099 )
...
* Update error messages
* validate lettings allocation
* Switch question field numbers
2 years ago
1098e6f2c5
CLDC-3028 Allow bulk uploading for merged organisations ( #2067 )
...
* Allow bulk uploading for merged organisations
* Allow bu for absorbed orgs with moved users
2 years ago
eb7f301974
CLDC-2071 Add intermediate rent error to BU ( #2053 )
...
* Add intermediate rent error
* Make sure field 12 as an error
2 years ago
fe98d89042
Remove import code ( #2047 )
...
* Move rent type to lettings log model
* Remove import and old rake tasks
2 years ago
f3177f612d
CLDC-2982 Make bulk upload user emails case insensitive ( #2017 )
...
* feat: match email regardless of casing in bulk upload
* feat: allow null emails
* feat: set encoding by bom for file IO before parsing
* Revert "feat: set encoding by bom for file IO before parsing"
This reverts commit 03d2d17e7b
2 years ago
60496adf08
feat: update scheme and location lookup to search for exact correct combination of org, scheme and location ( #2016 )
2 years ago
2c24f2bcab
Remove uprn validation for supported housing logs ( #1992 )
2 years ago
4068d7a2f6
CLDC-2871 Fix bulk upload scheme lookup bug ( #1971 )
...
* feat: wip tests
* feat: update tests and functionality
* refactor: lint
* feat: update tests and don't add errors to scheme/location fields unless determined
* feat: update duplicate log behaviour and tests
* refactor: lint
* feat: use needstype helpers
* feat: use needstype helpers and test tweak
* feat: make tests explicit regarding needstype
* feat: make tests explicit regarding needstype
2 years ago
a1527e48f7
Add duplicate log error if the chcharges are the same ( #1942 )
2 years ago
3b53e3e696
Remove homelessness validation ( #1877 )
2 years ago
abf9aa07a9
CLDC-2665 Switch lettings ppcodenk ( #1854 )
...
* Switch lettings ppcodenk
* Address Kat's comment
* separate process postcode methods
* tests
* Update row parsers
* Update conditionals
* Add rake task to update ppcodenk
* Bring back value_is_no?
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
6e8acbc927
Set housingneeds other to no if any of the housing needs are given ( #1812 )
3 years ago
3fc5a68a36
CLDC-2494 Add duplicate logs page ( #1763 )
...
* CLDC-2494: WIP
* CLDC-2494: wip
* CLDC-2494: page work in progress
* cleanup
* Add a path for duplicate logs
* Display all duplicate logs
* Move a test
* Display duplicate check answers for logs
* Add buttons to delete duplicates
* Add a route for sales logs duplicates
* Update duplicated page to work for sales logs
* Update styling
* lint
* Add auth
* Rebase updates
* Remove propcode from dedulication checks
* Update fields to work with supported housing
* Trigger duplicate log check on buyer 1 age not known
* compare correct charges
* Update displayed questions
* BU test
* Put redirect to duplicate logs path behind a feature flag
* More BU tests
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
3 years ago
960b633ac5
CLDC-2474 Allow numeric fields to accept decimal representations in bulk upload ( #1753 )
...
* feat: allow decimals for lettings type when they only have trailing 0s and add tests
* refactor: linting
* refactor: DRY tests
* refactor: linting
3 years ago
e759c3522a
Correct typo in location not found bulk upload error message ( #1759 )
...
* feat: update copy
* feat: update copy
3 years ago
503417081b
CLDC-2318 Update duplicate logs errors ( #1750 )
...
* Update duplicate logs check for 2022 lettings
* Update duplicate logs check for 2023 lettings
* Remove unneeded conditional
* Test
* refactor
3 years ago
ab33b181fc
CLDC-2499 Fix housingneeds_type bug ( #1746 )
...
* feat: set none of listed options for housingneeds_type in bu parsers
* feat: add tests
3 years ago
0a0f26ca2b
Update questions ( #1724 )
3 years ago
84027b63b2
do not add soft validations to fields related to unrouted questions ( #1713 )
3 years ago
a3e459c099
CLDC-2436 Multiple checkbox field bu bug ( #1687 )
...
* feat: add checkbox clearing behaviour
* feat: fix ££ bug
* feat: unfix ££ bug, leave to another ticket
* feat: fix homeless assignment bug
* refactor: simplify wip
* feat: validate reasonable preference/homeless in bu 23
* feat: validate reasonable preference/homeless in bu 22
* refactor: simplify
* feat: actually clear values
* feat: add specific errors to condition_effects
* feat: add specific errors to condition_effects
* feat: add tests
* refactor: lint
* feat: update tests
* feat: add additional null checks
* feat: add additional null checks to sales
* feat: fix string/sym assignment
* feat: add tests
3 years ago
aa4c250b3c
CLDC-2390 CYA address redesign ( #1696 )
...
* feat: update cya design lettings
* feat: update cya sales
* feat: update some tests
* feat: fix error labels for address questions
* feat: fix error labels for address questions and update row parsers
* feat: update tests
* feat: update tests
* feat: rename display_label
3 years ago
7bfe3f4d75
CLDC-2447 Bulk upload 23-24 lettings net income known bug ( #1695 )
...
* feat: fix bug
* feat: update tests
* feat: test ALL possibilities
3 years ago
c5842122d7
CLDC-2369 Spreadsheet dupe ( #1663 )
...
* remove dead code
* handle spreadsheet dupes in lettings
* handle spreadsheet dupes in sales
* update error message
* use feature flag
3 years ago
928af7b6d9
Only loop through existing field mappings for errors ( #1648 )
...
* Only loop through existing field mapings for errors
* Add a test
3 years ago
336d9ffe6f
CLDC-2357 Correct sales bulk upload UPRN errors ( #1626 )
...
* feat: process postcode changes to clear la etc when uprn errors clear values
* refactor: how_fix -> how_to_fix
* feat: explicitly blank uprn
* feat: add uprn to error mapping
* refactor: typos
* refactor: cleanup
* feat: make postcode secretly optional, same as lettings
* test: update
* test: add main tests
* feat: remove unneccessary assignement
* feat: add fix choice error message to sales
* feat: typo fix
* refactor: lint
3 years ago
0fea8585ec
CLDC-2354 Add soft validation messages to 23/24 sales ( #1627 )
...
* Add soft validation messages to 23/24 sales
* Refactor return and tests
* More flaky tests
3 years ago
f32dfd6d2f
Set uprn confirmed ( #1624 )
3 years ago
Manny Dinssa
kosiakkatrina
Rachael Booth
natdeanlewissoftwire
Jack
Aaron Spencer
Arthur Campbell
Phil Lee