natdeanlewissoftwire
639efc9887
Merge branch 'main' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
Jack
5aba3ef9a9
Run rent validations when >= 4 beds ( #1465 )
3 years ago
Phil Lee
b262178923
bulk upload ageN check depends on other fields ( #1468 )
...
- if other fields for a person are present but the age is not we ask
them to enter their age
3 years ago
Phil Lee
d42a37c08e
permit at least one housing need ( #1470 )
3 years ago
natdeanlewissoftwire
9daba81e4c
feat: confirm locations when complete even if save button not clicked, and update tests
3 years ago
natdeanlewissoftwire
cc94aec762
Merge branch 'main' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
Arthur Campbell
9f3b2bba28
CLDC-2032 test log creation in crossover period ( #1420 )
...
* ensure that no form is added to the forms hash under the key "nil"
* add a test to ensure that the form handler does not add outdated forms to the forms hash with key nil
* remove unnecessary singleton reinitialisation
* remove a duplicated Timecop around block
3 years ago
Jack
ea810beab1
Address UPRN PO review ( #1467 )
...
* Fix question number rendering
* Update title copy
3 years ago
Phil Lee
8d9c577e69
disable start date validation for staging ( #1466 )
3 years ago
kosiakkatrina
cf46ae46fe
CLDC-2131 Update pregnancy validation ( #1458 )
...
* Remove hard pregnancy validation and update soft validation
* Remove validate_pregnancy references
* Don't care about the age in gender validation
3 years ago
natdeanlewissoftwire
6112086568
Merge branch 'main' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
Phil Lee
c9473c9362
cannot create log if owning or mangaging data bad ( #1464 )
...
- for bulk upload
3 years ago
natdeanlewissoftwire
3718143cfa
refactor: consistent use of factorybot or not within a file
3 years ago
natdeanlewissoftwire
fb1e801949
Merge branch 'CLDC-1854-make-empty-schemes-show-inactive' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
natdeanlewissoftwire
c35366d8b2
Merge branch 'main' into CLDC-1854-make-empty-schemes-show-inactive
3 years ago
natdeanlewissoftwire
c74553c3d1
Merge branch 'CLDC-1854-make-empty-schemes-show-inactive' into CLDC-2140-scheme-typeahead-with-inactive-locations
...
# Conflicts:
# spec/helpers/schemes_helper_spec.rb
3 years ago
natdeanlewissoftwire
ccf6252256
Merge branch 'main' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
natdeanlewissoftwire
6acb27ed71
refactor: linting
3 years ago
natdeanlewissoftwire
1af137eaf1
feat: test when location is confirmed
3 years ago
natdeanlewissoftwire
c70dcafd8e
feat: test when scheme is confirmed for support user
3 years ago
natdeanlewissoftwire
cf6d87dcc5
feat: test when scheme is confirmed
3 years ago
natdeanlewissoftwire
a604dfb652
feat: test validation
3 years ago
natdeanlewissoftwire
3bf0f30d10
feat: test unconfirmed locations aren't options in location_id
3 years ago
natdeanlewissoftwire
e928ebddba
feat: test incomplete count too
3 years ago
natdeanlewissoftwire
0966bd6869
CLDC-2020 Add saledate less than 2 weeks from today validation ( #1446 )
...
* feat: copy updates and add saledate validation
* feat: rename methods and enable feature toggle
* feat: rename methods and enable feature toggle
* test: add tests
* refactor: ruby police
* feat: fix tests
* refactor: readability
* feat: enable validation on review apps
* db:update
3 years ago
natdeanlewissoftwire
fb7d075fa1
refactor: linting
3 years ago
natdeanlewissoftwire
48ed1929d3
feat: add tests for incomplete schemes
3 years ago
kosiakkatrina
fa8676b8ea
Lettings log import validations ( #1463 )
...
* Clear import fields failing non_temp_accommodation validation
* Clear joint tenancy if there is only 1 person in the household
* Clear offered if the value is above the maximum of 20
* Display error message on ecstat
* Remove ecstat if the income is too high for it
3 years ago
James Rose
2440e8a2ef
Update service charge validations ( #1428 )
...
* Update service charge validations
* Create location deactivation periods instead of setting a scheme end date
* Add test for deactivation period
* Update ranges in tests
* Remove scheme validation test
* Check that the location gets confirmed
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
3 years ago
natdeanlewissoftwire
5bb906563a
refactor: rubocop
3 years ago
natdeanlewissoftwire
8ea9daf3d5
refactor: rubocop
3 years ago
natdeanlewissoftwire
79c16f7094
refactor: rubocop
3 years ago
natdeanlewissoftwire
f5a04382e8
feat: fix more tests
3 years ago
Phil Lee
0b973ceebd
add new uprn and address fields to bulk upload ( #1462 )
3 years ago
kosiakkatrina
5c20a46a1b
CLDC-2143 Resolve more import validations ( #1454 )
...
* Remove failing equity over max on import
* Remove failing equity under min on import
* Use LA instead of postcode if postcode is in invalid format
* Do not backfill information about people indexed 7 and higher
* Unskip test
3 years ago
natdeanlewissoftwire
4da36d28ee
feat: fix more tests
3 years ago
natdeanlewissoftwire
83d8de341b
feat: fix tests
3 years ago
Phil Lee
ffcfa7db6e
bulk upload age can be null ( #1459 )
3 years ago
natdeanlewissoftwire
f7a0eb01dd
Merge remote-tracking branch 'origin/CLDC-2140-scheme-typeahead-with-inactive-locations' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
natdeanlewissoftwire
d569e78d57
refactor: complete -> confirm
3 years ago
natdeanlewissoftwire
1d7dc1c774
feat: add unconfirmed scope
3 years ago
natdeanlewissoftwire
c0f9088251
feat: only confirm locations if complete (old) AND save button clicked (new)
3 years ago
natdeanlewissoftwire
6a4605394c
feat: reject incomplete locations
3 years ago
natdeanlewissoftwire
005b21a2b4
feat: update scheme typeahead text
3 years ago
natdeanlewissoftwire
7d20066d6f
feat: improve copy
3 years ago
natdeanlewissoftwire
9d961acb20
feat: show completed/incomplete locations and validate when completed == 0
3 years ago
natdeanlewissoftwire
14e2346e12
feat: reject incomplete locations
3 years ago
natdeanlewissoftwire
90be5bff57
feat: update scheme typeahead text
3 years ago
natdeanlewissoftwire
20326fd55b
feat: fix tests
3 years ago
Arthur Campbell
97bbf1924d
CLDC-2016 mortgage validation ( #1445 )
...
* add method to sales log and use in depends on to increase readability
* increase minimum allowed value for mortgage
* write tests and add validation error to config for new validation
* write validation
* adjust validation so it doesn't trigger when mortgage value is derived as 0
* correct linting problem and update tests to account for change in validation
3 years ago